-
Notifications
You must be signed in to change notification settings - Fork 1.2k
dns/dnsmessage: update SVCB packing to prohibit name compression #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: 1d16664) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/713900. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from Vinicius Fortuna: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from t hepudds: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from Vinicius Fortuna: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from Mateusz Poliwczak: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from Vinicius Fortuna: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from Vinicius Fortuna: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from t hepudds: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-10-22T21:22:45Z","revision":"20de74c4a68f29f2c67b1f63c3f7cf790a3b4838"} Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from t hepudds: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
Message from Damien Neil: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
This commit updates the dns/dnsmessage package to correctly handle SVCB record packing by prohibiting name compression for the Target field. It turns out the compression of names in RDATA is prohibited (see https://datatracker.ietf.org/doc/html/rfc3597#section-4), except for well-known record types (those defined in https://datatracker.ietf.org/doc/html/rfc1035). The SVCB RFC actually explicitly calls that out (https://datatracker.ietf.org/doc/html/rfc9460#section-2.2), so it was an oversight in my part in https://go.dev/cl/710736. Updates golang/go#43790 Change-Id: I287b034c9e01b49264e07e23293bacd830ab1832 GitHub-Last-Rev: 1d16664 GitHub-Pull-Request: #242 Reviewed-on: https://go-review.googlesource.com/c/net/+/713900 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Vinicius Fortuna <fortuna@google.com> Reviewed-by: Damien Neil <dneil@google.com> Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Sean Liao <sean@liao.dev>
|
Message from Sean Liao: Patch Set 2: Auto-Submit+1 Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/713900. |
|
This PR is being closed because golang.org/cl/713900 has been merged. |
This commit updates the dns/dnsmessage package to correctly handle SVCB record
packing by prohibiting name compression for the Target field.
It turns out the compression of names in RDATA is prohibited (see
https://datatracker.ietf.org/doc/html/rfc3597#section-4), except for well-known record
types (those defined in https://datatracker.ietf.org/doc/html/rfc1035).
The SVCB RFC actually explicitly calls that out
(https://datatracker.ietf.org/doc/html/rfc9460#section-2.2), so it was an oversight
in my part in https://go.dev/cl/710736.
Updates golang/go#43790