Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: add Google's endpoint to blacklist #326

Closed
wants to merge 2 commits into from

Conversation

avinassh
Copy link

Today morning, all our machines on production started breaking cos of change in Google Oauth. They no longer accept basic auth and due to this login fails. This patch fixes it by adding google URL to blacklist.

related: https://twitter.com/russell_h/status/1045171495490605057

@gopherbot
Copy link
Contributor

This PR (HEAD: fcc1fda) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/138015 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/138015.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 6365729) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/138015 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 2:

According to your tweet thread, this was fixed server-side, so I assume this change is no longer necessary?


Please don’t reply on this GitHub thread. Visit golang.org/cl/138015.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 13736:

Patch Set 2:

Patch Set 2:

According to your tweet thread, this was fixed server-side, so I assume this change is no longer necessary?

I checked again in our deployments with older version and for now it seems to be working fine. Is there any way to confirm that there was indeed a fix made at server side?


Please don’t reply on this GitHub thread. Visit golang.org/cl/138015.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 7295:

Patch Set 2:

Patch Set 2:

Patch Set 2:

According to your tweet thread, this was fixed server-side, so I assume this change is no longer necessary?

I checked again in our deployments with older version and for now it seems to be working fine. Is there any way to confirm that there was indeed a fix made at server side?

Right, I'd like to try to confirm that the server-side fix was deliberate and permanent before abandoning this change. If anyone can comment directly on that it would help.


Please don’t reply on this GitHub thread. Visit golang.org/cl/138015.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot closed this in 80673b4 Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants