Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Refresh Token Redirect URI #559

Closed
wants to merge 17 commits into from

Conversation

davids-codex
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Mar 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@davids-codex davids-codex marked this pull request as draft March 22, 2022 21:06
@davids-codex davids-codex changed the title Support Redirect URI Refresh Token Support Refresh Token Redirect URI Mar 22, 2022
@davids-codex davids-codex marked this pull request as ready for review March 22, 2022 21:27
@gopherbot
Copy link
Contributor

This PR (HEAD: 1556119) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/394696 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/394696.
After addressing review feedback, remember to publish your drafts!

@davids-codex davids-codex marked this pull request as draft March 22, 2022 21:45
@gopherbot
Copy link
Contributor

This PR (HEAD: f680a8b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/394696 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 31c0cf9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/394696 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 7082c6c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/394696 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 67a55f1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/394696 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@davids-codex
Copy link
Author

/comments off

Copy link

@zs-codex zs-codex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; just one minor suggestion.

oauth2.go Outdated Show resolved Hide resolved
Co-authored-by: Zane Silver <66640799+zs-codex@users.noreply.github.com>
@davids-codex davids-codex marked this pull request as ready for review March 24, 2022 00:07
@davids-codex davids-codex deleted the patch-1 branch October 5, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants