-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to standard library context package. #275
Conversation
Thanks for the suggestions. This would break compatibility with Go 1.6 and we generally support the last two versions of Go (1.6 and 1.7). As you've mentioned, Go 1.8 release in soon (less than a month). Let's hold off on this until then, so we don't have to complicate things with build tags. |
Go 1.8 is now out, could this be merged in? |
Hey there @dsnet, checking up on this. Do you think this is ready to merge? |
@dsnet or @neild (you've been active lately) Can this be merged? It is blocking metaverse/truss#148 which prevents us from updating our services to the latest gokit. |
Isn't this going to break, like, everybody on AppEngine? (They're still on 1.6, I think.) A proper fix for this issue is for x/net to use aliases on 1.8.typealias and 1.9. |
Well I guess this change got reverted. |
Any explanation for why this was reverted? |
@andremarianiello, because it doesn't work with grpc, which still imports Changing this and grpc means breaking backward compatibility, which is important to many of our users. Meanwhile, if you're on Go1.9, If you're using an older version, Go 1.8's fix tool has a recipe for this. |
Thanks for the info and the workarounds. |
There are people who are still using Go1.8. Given that we usually support the last two releases, I don't think we can reasonably roll-forward this change until all major users are on Go1.9 and above. I also don't want to have the generator produce two different build-tagged files. |
Go 1.7 added context to the standard library. With Go 1.8 coming soon here is a PR to switch from
golang.org/x/net/context
to `context.