Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-go/generator: fix misspelling #732

Merged
merged 3 commits into from
Oct 22, 2018
Merged

protoc-gen-go/generator: fix misspelling #732

merged 3 commits into from
Oct 22, 2018

Conversation

chemidy
Copy link
Contributor

@chemidy chemidy commented Oct 21, 2018

No description provided.

@dsnet
Copy link
Member

dsnet commented Oct 21, 2018

Thanks! Please revert all changes that are unrelated to the misspell fix.

@dsnet dsnet changed the title fix misspell protoc-gen-go/generator: fix misspell Oct 22, 2018
@dsnet dsnet changed the title protoc-gen-go/generator: fix misspell protoc-gen-go/generator: fix misspellfix misspell Oct 22, 2018
@dsnet dsnet changed the title protoc-gen-go/generator: fix misspellfix misspell protoc-gen-go/generator: fix misspelling Oct 22, 2018
@dsnet dsnet merged commit 7be3631 into golang:master Oct 22, 2018
@dsnet
Copy link
Member

dsnet commented Oct 22, 2018

FYI, I'm not able to merge this. seems to be an issue with GitHub:

Couldn't update branch
Oops, something went wrong.

I'll try again later.

1 similar comment
@dsnet
Copy link
Member

dsnet commented Oct 22, 2018

FYI, I'm not able to merge this. seems to be an issue with GitHub:

Couldn't update branch
Oops, something went wrong.

I'll try again later.

dsnet added a commit that referenced this pull request Nov 27, 2018
Change-Id: I908a183499bc539b722f7f32ae83f6662ea729aa
Cherry-Pick: github.com/golang/protobuf@7be3631955993a734965532f776bad7093f6fc9d
Original-Author: Cyrille Hemidy <cyrille.hemidy@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/151425
Reviewed-by: Damien Neil <dneil@google.com>
@golang golang locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants