Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

Fix binary.Uvarint overflow. #13

Closed
wants to merge 1 commit into from
Closed

Conversation

makhov
Copy link

@makhov makhov commented Jun 1, 2015

@dvyukov found a bug with his go-fuzz

panic: runtime error: index out of range

goroutine 1 [running]:
github.com/golang/snappy/snappy.Decode(0x0, 0x0, 0x0, 0xc208041f00, 0xa, 0x20, 0x0, 0x0, 0x0, 0x0, ...)
    src/github.com/golang/snappy/snappy/decode.go:54 +0xaca
main.main()
    snappy.go:11 +0xf6

More info at #11.

@makhov
Copy link
Author

makhov commented Jun 3, 2015

There is no snappy project at https://go-review.googlesource.com/#/admin/projects/

@dvyukov
Copy link
Member

dvyukov commented Jun 3, 2015

@nigeltao Can you advise on this? Why is there no snappy project at go-review?

@nigeltao
Copy link
Contributor

Thanks for the patch, but I don't think this is the right fix. Such input should return ErrCorrupt.

In any case, we should have a test as well.

I'll cook up a commit.

@nigeltao nigeltao closed this Jul 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants