all: use grep -E/-F instead of fgrep/egrep #137
Conversation
Change-Id: Iedeb3433c5d27488e7de0199a7f3effe1d79c82a
|
This PR (HEAD: 637e5ad) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/432835 to see it. Tip: You can toggle comments from me using the |
|
Message from Tobias Klauser: Patch Set 1: Run-TryBot+1 Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432835. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432835. |
|
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432835. |
|
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432835. |
Change-Id: I1d9ccc8dd70051a962a2cc5195cb08148d5c3549
|
This PR (HEAD: 9f5c279) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/432835 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 1eee614) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/432835 to see it. Tip: You can toggle comments from me using the |
|
Message from Pengfei Ren: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432835. |
|
Message from Ian Lance Taylor: Patch Set 3: Run-TryBot+1 Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432835. |
|
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432835. |
|
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/432835. |
egrep and fgrep are obsolescent now. This PR updates all egrep and fgrep commands to grep -E and grep -F. Running egrep/fgrep command with grep v3.8 will output the following warning to stderr: egrep: warning: egrep is obsolescent; using grep -E see also: https://www.phoronix.com/news/GNU-Grep-3.8-Stop-egrep-fgrep https://lists.gnu.org/archive/html/info-gnu/2022-09/msg00001.html Change-Id: I0c6b6a039063d6aee94e8500971001996d4e498c GitHub-Last-Rev: 1eee614 GitHub-Pull-Request: #137 Reviewed-on: https://go-review.googlesource.com/c/sys/+/432835 Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
|
This PR is being closed because golang.org/cl/432835 has been merged. |
egrep and fgrep are obsolescent now.
This PR updates all egrep and fgrep commands to grep -E and grep -F.
Running egrep/fgrep command with grep v3.8 will output the following warning to stderr:
egrep: warning: egrep is obsolescent; using grep -E
see also:
https://www.phoronix.com/news/GNU-Grep-3.8-Stop-egrep-fgrep
https://lists.gnu.org/archive/html/info-gnu/2022-09/msg00001.html