windows: add GetAce Windows API #191

claudiubelu · 2024-04-15T20:26:11Z

GetAce obtains a pointer to an access control entry (ACE) in an
discretionary access control list (DACL), which controls access to
an object.

Adds the ACE_HEADER and ACCESS_ALLOWED_ACE structs.
Adds GetEntriesFromACL function which returns an array of ACEs from the
given ACL if no errors have been encountered.

References:

Fixes golang/go#66850

google-cla · 2024-04-15T20:26:16Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2024-04-15T21:03:02Z

This PR (HEAD: c973250) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-15T21:09:35Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-15T21:09:35Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-16T11:25:40Z

This PR (HEAD: b911428) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-16T11:32:08Z

Message from Claudiu Belu:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-29T11:08:24Z

This PR (HEAD: 80961ac) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-31T09:31:15Z

Message from Alex Brainman:

Patch Set 4: Commit-Queue+1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-31T09:37:47Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-31T09:26:06Z","revision":"d735e1d438321cc1c168e3bb56f327a3ecb40155"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-31T09:37:47Z

Message from Alex Brainman:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-31T09:37:48Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Failed Tryjobs:

golang/try/x_sys-go1.22-windows-amd64. Summary (view all results):

go on release-branch.go1.22 (commit 7456575)
sys on master (change 578976)

Build or test failure, click here for results.

Additional links for debugging:

Output for test golang.org/x/sys module

golang/try/x_sys-gotip-linux-amd64-misccompile. Summary (view all results):

go on master (commit 5bf8c0c)
sys on master (change 578976)

Error:

shard 3: failed to run test golang.org/x/sys module for goos:"windows"  goarch:"arm": exit status 1
failed to run test golang.org/x/sys module for goos:"windows"  goarch:"arm64": exit status 1

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-31T09:37:48Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-31T09:44:19Z

Message from Alex Brainman:

Patch Set 4: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-31T09:50:46Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-05-31T09:37:15Z","revision":"d735e1d438321cc1c168e3bb56f327a3ecb40155"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-31T09:50:47Z

Message from Alex Brainman:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-31T09:50:47Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/x_sys-gotip-linux-amd64-misccompile has failed with summary (view all results):

go on master (commit 5bf8c0c)
sys on master (change 578976)

Error:

shard 3: failed to run test golang.org/x/sys module for goos:"windows"  goarch:"arm": exit status 1
failed to run test golang.org/x/sys module for goos:"windows"  goarch:"arm64": exit status 1

Additional links for debugging:

Output for test golang.org/x/sys module for goos:"windows" goarch:"arm" [shard 3]
Output for test golang.org/x/sys module for goos:"windows" goarch:"arm64" [shard 3]
Shard 3 encountered a non-build/non-test failure, click here for the shard's build page

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-03T10:13:40Z

This PR (HEAD: 9caf768) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-03T10:27:08Z

This PR (HEAD: 9cd77c1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-03T10:33:37Z

Message from Claudiu Belu:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-13T10:33:20Z

Message from Alex Brainman:

Patch Set 6: Commit-Queue+1

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-13T10:39:59Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-13T10:24:48Z","revision":"145113fd357662d7182ed7e281f035adf3d0041d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-13T10:40:00Z

Message from Alex Brainman:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-13T10:40:00Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-13T10:40:01Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

GetAce obtains a pointer to an access control entry (ACE) in an discretionary access control list (DACL), which controls access to an object. Adds the ACE_HEADER and ACCESS_ALLOWED_ACE structs. Adds GetEntriesFromACL function which returns an array of ACEs from the given ACL if no errors have been encountered. References: - https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-ace_header - https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-access_allowed_ace - https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-getace Fixes golang/go#66850

gopherbot · 2024-06-17T15:20:28Z

This PR (HEAD: d14ca7f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/578976.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-17T15:27:32Z

Message from Claudiu Belu:

Patch Set 7:

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-23T09:07:26Z

Message from Alex Brainman:

Patch Set 8: Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-23T09:13:23Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-23T09:02:37Z","revision":"9cec0cf9f1206c8590de922752ea9eac91222c0c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-23T09:13:24Z

Message from Alex Brainman:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-23T09:13:24Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-23T09:13:25Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-23T09:25:17Z

Message from Alex Brainman:

Patch Set 8: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-24T01:20:46Z

Message from David Chase:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

GetAce obtains a pointer to an access control entry (ACE) in an discretionary access control list (DACL), which controls access to an object. Adds the ACE_HEADER and ACCESS_ALLOWED_ACE structs. Adds GetEntriesFromACL function which returns an array of ACEs from the given ACL if no errors have been encountered. References: - https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-ace_header - https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-access_allowed_ace - https://learn.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-getace Fixes golang/go#66850 Change-Id: I98306ff7e947e586a58d563d364169a2555492f4 GitHub-Last-Rev: d14ca7f GitHub-Pull-Request: #191 Reviewed-on: https://go-review.googlesource.com/c/sys/+/578976 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

gopherbot · 2024-06-24T03:05:10Z

Message from Damien Neil:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/578976.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-24T03:11:16Z

This PR is being closed because golang.org/cl/578976 has been merged.

GetAce expects a failretval==0, and we shouldn't call GetLastError on error. Fixes golang#191 Updates golang#191

claudiubelu mentioned this pull request Apr 15, 2024

Windows file permissions kubernetes/kubernetes#104660

Closed

claudiubelu changed the title ~~windows: Adds GetAce syscall wrapper~~ adds Windows GetAce syscall wrapper Apr 16, 2024

claudiubelu force-pushed the windows/adds-acl-ace branch from c973250 to b911428 Compare April 16, 2024 11:20

claudiubelu mentioned this pull request Apr 16, 2024

proposal: x/sys/windows: Add GetAce syscall golang/go#66850

Closed

claudiubelu force-pushed the windows/adds-acl-ace branch from b911428 to 80961ac Compare April 29, 2024 11:03

claudiubelu force-pushed the windows/adds-acl-ace branch from 80961ac to 9caf768 Compare June 3, 2024 10:09

claudiubelu force-pushed the windows/adds-acl-ace branch from 9caf768 to 9cd77c1 Compare June 3, 2024 10:23

claudiubelu changed the title ~~adds Windows GetAce syscall wrapper~~ windows: add GetAce Windows API Jun 14, 2024

claudiubelu force-pushed the windows/adds-acl-ace branch from 9cd77c1 to d14ca7f Compare June 17, 2024 15:20

gopherbot closed this Jun 24, 2024

aymanbagabas mentioned this pull request Jul 18, 2024

windows: correctly generate GetAce syscall #205

Closed

aymanbagabas added a commit to aymanbagabas/sys that referenced this pull request Jul 19, 2024

windows: correctly generate GetAce syscall

40cf750

GetAce expects a failretval==0, and we shouldn't call GetLastError on error. Fixes golang#191 Updates golang#191

windows: add GetAce Windows API #191

windows: add GetAce Windows API #191

Conversation

claudiubelu commented Apr 15, 2024 • edited Loading

google-cla bot commented Apr 15, 2024

gopherbot commented Apr 15, 2024

gopherbot commented Apr 15, 2024

gopherbot commented Apr 15, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 29, 2024

gopherbot commented May 31, 2024

gopherbot commented May 31, 2024

gopherbot commented May 31, 2024

gopherbot commented May 31, 2024

gopherbot commented May 31, 2024

gopherbot commented May 31, 2024

gopherbot commented May 31, 2024

gopherbot commented May 31, 2024

gopherbot commented May 31, 2024

gopherbot commented Jun 3, 2024

gopherbot commented Jun 3, 2024

gopherbot commented Jun 3, 2024

gopherbot commented Jun 13, 2024

gopherbot commented Jun 13, 2024

gopherbot commented Jun 13, 2024

gopherbot commented Jun 13, 2024

gopherbot commented Jun 13, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 17, 2024

gopherbot commented Jun 23, 2024

gopherbot commented Jun 23, 2024

gopherbot commented Jun 23, 2024

gopherbot commented Jun 23, 2024

gopherbot commented Jun 23, 2024

gopherbot commented Jun 23, 2024

gopherbot commented Jun 24, 2024

gopherbot commented Jun 24, 2024

gopherbot commented Jun 24, 2024

claudiubelu commented Apr 15, 2024 •

edited

Loading