Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix: add riscv64 tag to endian_little.go #38

Closed
wants to merge 1 commit into from
Closed

unix: add riscv64 tag to endian_little.go #38

wants to merge 1 commit into from

Conversation

carlosedp
Copy link
Contributor

@carlosedp carlosedp commented Jul 25, 2019

@gopherbot
Copy link

This PR (HEAD: f4470e4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187637 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/187637.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 9889a3d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187637 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@carlosedp carlosedp changed the title add riscv64 to endian_little unix: add riscv64 tag to endian_little.go Jul 25, 2019
@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 3:

You need to change the PR title, too, as it becomes the first line in Gerrit. See https://golang.org/wiki/CommitMessage. Thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187637.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 4:

Thanks, now remove the duplicate line in the first comment. To see what it looks like in Gerrit, see https://golang.org/cl/187637.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187637.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: a18db68) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/187637 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Carlos Eduardo de Paula:

Patch Set 6:

I think it's good now :)

Thanks for the patience... I'll get Gerrit some day.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187637.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 6: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/187637.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=7042add8


Please don’t reply on this GitHub thread. Visit golang.org/cl/187637.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 6: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/187637.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jul 26, 2019
Update golang/go#27532

Change-Id: I302f7db344e7704000b6e0c976519965b4f6a4ee
GitHub-Last-Rev: a18db68
GitHub-Pull-Request: #38
Reviewed-on: https://go-review.googlesource.com/c/sys/+/187637
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/187637 has been merged.

@gopherbot gopherbot closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants