Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update x/tools to HEAD #32

Closed
wants to merge 2 commits into from
Closed

Conversation

yarcat
Copy link
Contributor

@yarcat yarcat commented Aug 9, 2022

go get -u golang.org/x/tools
go mod tidy

x/tools/go/ssa is used by message/pipeline. Generics instantiation in
x/tools@0.1.11 could be confused with container index. However,
x/tools/go/ssa does have it fixed in x/tools@0.1.12 (see golang/go#52834).
This change upgrades the required version to ensure that fewer users of
message/pipelines have issues.

Updates golang/go#54086

@gopherbot
Copy link
Contributor

This PR (HEAD: d018104) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/422414 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/422414.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 1: Run-TryBot+1

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/422414.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/422414.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/422414.
After addressing review feedback, remember to publish your drafts!

go get -u golang.org/x/tools
go mod tidy

x/tools/go/ssa is used by message/pipeline. Generics instantiation in
x/tools@0.1.11 could be confused with container index. However,
x/tools/go/ssa does have it fixed in x/tools@0.1.12 (see golang/go#52834).
This change upgrades the required version to ensure that fewer users of
message/pipelines have issues.

Updates golang/go#54086
@gopherbot
Copy link
Contributor

This PR (HEAD: 0f46ec0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/422414 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jaroslavs Samcuks:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/422414.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jaroslavs Samcuks:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/422414.
After addressing review feedback, remember to publish your drafts!

go get -u golang.org/x/tools
go mod tidy

x/tools/go/ssa is used by message/pipeline. Generics instantiation in
x/tools@0.1.11 could be confused with container index. However,
x/tools/go/ssa does have it fixed in x/tools@0.1.12 (see golang/go#52834).
This change upgrades the required version to ensure that fewer users of
message/pipelines have issues.

Updates golang/go#54086
@gopherbot
Copy link
Contributor

This PR (HEAD: 351404b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/422414 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jaroslavs Samcuks:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/422414.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tim King:

Patch Set 5: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/422414.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Peter Weinberger:

Patch Set 5: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/422414.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 12, 2022
go get -u golang.org/x/tools
go mod tidy

x/tools/go/ssa is used by message/pipeline. Generics instantiation in
x/tools@0.1.11 could be confused with container index. However,
x/tools/go/ssa does have it fixed in x/tools@0.1.12 (see golang/go#52834).
This change upgrades the required version to ensure that fewer users of
message/pipelines have issues.

Updates golang/go#54086

Change-Id: I03882a7bb2c75a8f16ef376d06f2cf714d39e7a2
GitHub-Last-Rev: 351404b
GitHub-Pull-Request: #32
Reviewed-on: https://go-review.googlesource.com/c/text/+/422414
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Tim King <taking@google.com>
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/422414 has been merged.

@gopherbot gopherbot closed this Aug 12, 2022
@yarcat yarcat deleted the upgrade-ssa-dep branch September 12, 2022 21:14
xhit pushed a commit to xhit/text that referenced this pull request Oct 10, 2022
go get -u golang.org/x/tools
go mod tidy

x/tools/go/ssa is used by message/pipeline. Generics instantiation in
x/tools@0.1.11 could be confused with container index. However,
x/tools/go/ssa does have it fixed in x/tools@0.1.12 (see golang/go#52834).
This change upgrades the required version to ensure that fewer users of
message/pipelines have issues.

Updates golang/go#54086

Change-Id: I03882a7bb2c75a8f16ef376d06f2cf714d39e7a2
GitHub-Last-Rev: 351404b
GitHub-Pull-Request: golang#32
Reviewed-on: https://go-review.googlesource.com/c/text/+/422414
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Tim King <taking@google.com>
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants