feat: removed allowImplicitNetworkAccess flag from settings #66861

Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
golang · Jun 22, 2024 · 1aad2de · 1aad2de
1 parent 3de08ac
commit 1aad2de
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 21 deletions.
diff --git a/gopls/internal/doc/api.json b/gopls/internal/doc/api.json
@@ -79,19 +79,6 @@
 				"Status": "experimental",
 				"Hierarchy": "build"
 			},
-			{
-				"Name": "allowImplicitNetworkAccess",
-				"Type": "bool",
-				"Doc": "allowImplicitNetworkAccess disables GOPROXY=off, allowing implicit module\ndownloads rather than requiring user action. This option will eventually\nbe removed.\n",
-				"EnumKeys": {
-					"ValueType": "",
-					"Keys": null
-				},
-				"EnumValues": null,
-				"Default": "false",
-				"Status": "experimental",
-				"Hierarchy": "build"
-			},
 			{
 				"Name": "standaloneTags",
 				"Type": "[]string",

diff --git a/gopls/internal/settings/settings.go b/gopls/internal/settings/settings.go
@@ -1053,12 +1053,6 @@ func (o *Options) set(name string, value any, seen map[string]struct{}) error {
 	case "analysisProgressReporting":
 		return setBool(&o.AnalysisProgressReporting, value)
 
-	case "allowImplicitNetworkAccess":
-		if err := setBool(&o.AllowImplicitNetworkAccess, value); err != nil {
-			return err
-		}
-		return softErrorf("gopls setting \"allowImplicitNetworkAccess\" is deprecated.\nPlease comment on https://go.dev/issue/66861 if this impacts your workflow.")
-
 	case "standaloneTags":
 		return setStringSlice(&o.StandaloneTags, value)
 

diff --git a/gopls/internal/test/integration/misc/configuration_test.go b/gopls/internal/test/integration/misc/configuration_test.go
@@ -239,7 +239,6 @@ func TestDeprecatedSettings(t *testing.T) {
 			"experimentalWorkspaceModule":    true,
 			"tempModfile":                    true,
 			"allowModfileModifications":      true,
-			"allowImplicitNetworkAccess":     true,
 		},
 	).Run(t, "", func(t *testing.T, env *Env) {
 		env.OnceMet(
@@ -249,7 +248,6 @@ func TestDeprecatedSettings(t *testing.T) {
 			ShownMessage("experimentalWatchedFileDelay"),
 			ShownMessage("tempModfile"),
 			ShownMessage("allowModfileModifications"),
-			ShownMessage("allowImplicitNetworkAccess"),
 		)
 	})
 }