Skip to content

Commit 7f3a258

Browse files
adonovangopherbot
authored andcommitted
gopls/internal/test/integration/misc: disable another staticcheck test
I missed a test in CL 584395. Updates golang/go#67262 Change-Id: I9edbaf46cd148631925d7d70d64cfff4eb7ff660 Reviewed-on: https://go-review.googlesource.com/c/tools/+/584298 Reviewed-by: Tim King <taking@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Alan Donovan <adonovan@google.com>
1 parent 8483344 commit 7f3a258

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

gopls/internal/test/integration/misc/staticcheck_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,13 @@ var FooErr error = errors.New("foo")
9494
func TestStaticcheckRelatedInfo(t *testing.T) {
9595
testenv.NeedsGo1Point(t, 20) // staticcheck is only supported at Go 1.20+
9696

97+
// CL 583778 causes buildir not to run on packages that use
98+
// range-over-func, since it might otherwise crash. But nearly
99+
// all packages will soon meet this description, so the
100+
// analyzers in this test will not run, and the test will fail.
101+
// TODO(adonovan): reenable once dominikh/go-tools#1494 is fixed.
102+
t.Skip("disabled until buildir supports range-over-func (dominikh/go-tools#1494)")
103+
97104
// TODO(golang/go#65249): re-enable and fix this test once we
98105
// update go.mod to go1.23 so that gotypesalias=1 becomes the default.
99106
if aliases.Enabled() {

0 commit comments

Comments
 (0)