Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: reenable tests suppressed due to lack of build{ssa,ir} support for range-over-func or gotypesalias=1 #67262

Closed
adonovan opened this issue May 8, 2024 · 6 comments
Closed

x/tools/gopls: reenable tests suppressed due to lack of build{ssa,ir} support for range-over-func or gotypesalias=1 #67262

adonovan opened this issue May 8, 2024 · 6 comments
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.17.0

Comments

@adonovan
Copy link
Member

adonovan commented May 8, 2024

A number of gopls tests have been skipped. We shouldn't forget to reenable them when the upstream issues are fixed.

Pending CL adding SSA support for range-over-func:

Upstream issues:
@adonovan adonovan added this to the gopls/v0.16.0 milestone May 8, 2024
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label May 8, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/584395 mentions this issue: gopls/internal/test/integration/misc: disable staticcheck test

@seankhliao seankhliao changed the title gopls: reenable tests suppressed due to lack of build{ssa,ir} support for range-over-func or gotypesalias=1 x/tools/gopls: reenable tests suppressed due to lack of build{ssa,ir} support for range-over-func or gotypesalias=1 May 8, 2024
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label May 8, 2024
gopherbot pushed a commit to golang/tools that referenced this issue May 8, 2024
@adonovan @gopherbot
gopls/internal/test/integration/misc: disable staticcheck test
8f9d159 
Until staticcheck supports range-over-func, gopls won't attempt
to run it on packages that use range-over-func, which is about to
be nearly all packages. Our existing tests will not work.
So, disable them for now.

Updates dominikh/go-tools#1494
Updates golang/go#67262

Change-Id: Ia498b6122cbb7d3797d5d552acbbf0b3dc736eb9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/584395
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/584298 mentions this issue: gopls/internal/test/integration/misc: disable another staticcheck test

gopherbot pushed a commit to golang/tools that referenced this issue May 8, 2024
@adonovan @gopherbot
gopls/internal/test/integration/misc: disable another staticcheck test
7f3a258 
I missed a test in CL 584395.

Updates golang/go#67262

Change-Id: I9edbaf46cd148631925d7d70d64cfff4eb7ff660
Reviewed-on: https://go-review.googlesource.com/c/tools/+/584298
Reviewed-by: Tim King <taking@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
@adonovan
Copy link
Member Author

adonovan commented May 30, 2024 •
edited
Loading

Current status:

@adonovan adonovan mentioned this issue May 31, 2024
Closed
@findleyr findleyr modified the milestones: gopls/v0.16.0, gopls/v0.17.0 Jun 4, 2024
@gabyhelp gabyhelp mentioned this issue Jun 12, 2024
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/623295 mentions this issue: Revert "gopls/internal/analysis: disable ssa/ir analyzers on range-over-func"

@findleyr
Copy link
Member

@adonovan what's left after the above fixes?

gopherbot pushed a commit to golang/tools that referenced this issue Oct 29, 2024
@adonovan
Revert "gopls/internal/analysis: disable ssa/ir analyzers on range-ov…
9d6e1a6 
…er-func"

This reverts commit a432b16 (CL 538778)

Reason for revert: workaround no longer needed.

Updates golang/go#67262

Change-Id: I995bca3a2d835880318ee2a68fa7352aa7ba8776
Reviewed-on: https://go-review.googlesource.com/c/tools/+/623295
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
@adonovan
Copy link
Member Author

Nothing, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.17.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr