x/tools/gopls: analysis crash analyzing new uses of go1.23 range iterators #67237
Comments
gopherbot
added
Tools
adonovan
added
gopls/analysis
|
Relevant Staticcheck issue: dominikh/go-tools#1494 |
|
Change https://go.dev/cl/583778 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
May 8, 2024
This change disables analyzers that cannot yet safely process go1.23 range-over-func statements, including buildssa and buildir. (This is done by poking in an additional Analyzer.Requires edge on a new temporary analyzer that fails when it sees a range-over-func.) We plan to revert this change when ssa and ir support the new feature, but this CL will unblock uses of it in the standard library which would otherwise cause gopls' tests to crash. Updates golang/go#67237 Updates dominikh/go-tools#1494 Change-Id: Ibed2a88da94fb84234b4410b6bc7562a493287ce Reviewed-on: https://go-review.googlesource.com/c/tools/+/583778 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com> Auto-Submit: Alan Donovan <adonovan@google.com>
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
May 8, 2024
This is a short-term stopgap to stop SSA-based tools from panicking in the SSA builder when it encounters a go1.23 range-over-func statement. A principled fix will follow soon in CL 555075. Updates golang/go#67237 Change-Id: I26f3b4ac15f8ae24aa5e93a188a6e8b70acc43f3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/584295 Reviewed-by: Tim King <taking@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
Change https://go.dev/cl/584295 mentions this issue: |
|
This was fixed by the two CLs above. Reenabling the suppressed features is tracked by #67262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@ianlancetaylor reports that gopls crashes in the
buildiranalyzer (which is staticcheck's fork of go/ssa and buildssa) when it encounters a range-over-func statement in new code he is trying to merge the to the stdslicespackage. Theirpackage doesn't yet support range-over-func. Nor does go/ssa (but see https://go.dev/cl/555075).As a matter of priority, we need to disable ssa- and ir-based analyzers on packages that use range-over-func. Then we need to fix these packages before go1.23.
The text was updated successfully, but these errors were encountered: