Revert "gopls/internal/analysis: disable ssa/ir analyzers on range-over-func"

This reverts commit a432b16 (CL 538778)

Reason for revert: workaround no longer needed.

Updates golang/go#67262

Change-Id: I995bca3a2d835880318ee2a68fa7352aa7ba8776
Reviewed-on: https://go-review.googlesource.com/c/tools/+/623295
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>

Author: adonovan

gopls/internal/analysis/norangeoverfunc/norangeoverfunc.go

@@ -50,7 +50,6 @@ import (
 	"golang.org/x/tools/gopls/internal/analysis/fillreturns"
 	"golang.org/x/tools/gopls/internal/analysis/infertypeargs"
 	"golang.org/x/tools/gopls/internal/analysis/nonewvars"
-	"golang.org/x/tools/gopls/internal/analysis/norangeoverfunc"
 	"golang.org/x/tools/gopls/internal/analysis/noresultvalues"
 	"golang.org/x/tools/gopls/internal/analysis/simplifycompositelit"
 	"golang.org/x/tools/gopls/internal/analysis/simplifyrange"
@@ -60,7 +59,6 @@ import (
 	"golang.org/x/tools/gopls/internal/analysis/unusedvariable"
 	"golang.org/x/tools/gopls/internal/analysis/useany"
 	"golang.org/x/tools/gopls/internal/protocol"
-	"honnef.co/go/tools/staticcheck"
 )
 
 // Analyzer augments a [analysis.Analyzer] with additional LSP configuration.
@@ -108,32 +106,7 @@ func (a *Analyzer) String() string { return a.analyzer.String() }
 var DefaultAnalyzers = make(map[string]*Analyzer) // initialized below
 
 func init() {
-	// Emergency workaround for #67237 to allow standard library
-	// to use range over func: disable SSA-based analyses of
-	// go1.23 packages that use range-over-func.
-	suppressOnRangeOverFunc := func(a *analysis.Analyzer) {
-		a.Requires = append(a.Requires, norangeoverfunc.Analyzer)
-	}
-	// buildir is non-exported so we have to scan the Analysis.Requires graph to find it.
-	var buildir *analysis.Analyzer
-	for _, a := range staticcheck.Analyzers {
-		for _, req := range a.Analyzer.Requires {
-			if req.Name == "buildir" {
-				buildir = req
-			}
-		}
-
-		// Temporarily disable SA4004 CheckIneffectiveLoop as
-		// it crashes when encountering go1.23 range-over-func
-		// (#67237, dominikh/go-tools#1494).
-		if a.Analyzer.Name == "SA4004" {
-			suppressOnRangeOverFunc(a.Analyzer)
-		}
-	}
-	if buildir != nil {
-		suppressOnRangeOverFunc(buildir)
-	}
-
+	// The traditional vet suite:
 	analyzers := []*Analyzer{
 		// The traditional vet suite:
 		{analyzer: appends.Analyzer, enabled: true},