Skip to content

Commit

Permalink
gopls/internal/regtest/codelens: increase the timeout on TestGCDetails
Browse files Browse the repository at this point in the history
Experiment with increasing the timeout for TestGCDetails, given how its
flakiness correlates with slow builders.

For golang/go#44099

Change-Id: I27a8732256a77c3d9ce2a1b1f75ce5d0fbc11e67
Reviewed-on: https://go-review.googlesource.com/c/tools/+/289690
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
  • Loading branch information
findleyr committed Feb 4, 2021
1 parent 6d19fbf commit bd8508e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions gopls/internal/regtest/codelens/codelens_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"runtime"
"strings"
"testing"
"time"

. "golang.org/x/tools/gopls/internal/regtest"

Expand Down Expand Up @@ -296,6 +297,8 @@ func main() {
CodeLenses: map[string]bool{
"gc_details": true,
}},
// TestGCDetails seems to suffer from poor performance on certain builders. Give it some more time to complete.
Timeout(60*time.Second),
).Run(t, mod, func(t *testing.T, env *Env) {
env.OpenFile("main.go")
env.ExecuteCodeLensCommand("main.go", source.CommandToggleDetails)
Expand Down

0 comments on commit bd8508e

Please sign in to comment.