-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
internal/lsp/source/completion: improve import suggestion labels
This change improves the labels for import suggestions to only show the last part of the path. Since VSCode fuzzy searches for labels in text edit, we now return only the last part of path as text edit instead of replacing the full import path. Just changing label while returning full path leads to bad user experience. Closes golang/go#35877 Change-Id: Ib10e7a3e030dc9b850ff1d9ec8d45240b75b64a3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/255837 Run-TryBot: Danish Dua <danishdua@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Danish Dua <danishdua@google.com>
- Loading branch information
Showing
3 changed files
with
67 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters