go/analysis: fix vet errors

[hasitpbhatt]

Updating tools version in go fails the builds due to go vet errors as it can be observed in https://golang.org/cl/196843.

Fix vet errors in facts.go and assign.go

Updates golang/go#34062

[gopherbot]

This PR (HEAD: ab5130d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/197338 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/197338.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Bryan C. Mills:

Patch Set 1: Run-TryBot+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/197338.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ef3f9033

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/197338.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Hasit Bhatt:

Patch Set 1:

Fix minor vet errors, as it is causing build fails for https://polymer2-go-review.googlesource.com/c/go/+/196843.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/197338.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Bryan C. Mills:

Patch Set 1:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/197338.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/197338.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 57d8329) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/197338 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Hasit Bhatt:

Patch Set 4:

(2 comments)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/197338.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Bryan C. Mills:

Patch Set 4: Run-TryBot+1 Code-Review+2

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/197338.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=d95a36a0

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/197338.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/197338 has been merged.