tools/gopls: add command line support for suggestedfix #174

kalmanb · 2019-10-21T18:55:40Z

This adds support for calling suggestedfix from the gopls command line, e.g.

$ gopls suggestedfix ~/tmp/foo/main.go

Optional arguments are:
-w, which writes the changes back to the original file; and
-d, which prints a unified diff to stdout
With no arguments, the changed files are printed to stdout.

Wasn't sure if the command should be suggestedfix or just fix or quickfix?
Also this applies all changes to a file, does not allow for selective fixes.

Updates golang/go#32875

This commit adds support for calling suggestedfix from the gopls command line, e.g. $ gopls suggestedfix ~/tmp/foo/main.go Optional arguments are: - -w, which writes the changes back to the original file; and - -d, which prints a unified diff to stdout With no arguments, the changed files are printed to stdout.

gopherbot · 2019-10-21T18:57:48Z

This PR (HEAD: a0a0341) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/202480 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-21T19:00:45Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

knight6782 · 2019-10-21T19:14:02Z

Please stop sending me emails

…

On Mon, Oct 21, 2019, 3:01 PM GopherBot ***@***.***> wrote: Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review. Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact. During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details. ------------------------------ Please don’t reply on this GitHub thread. Visit golang.org/cl/202480 <https://go-review.googlesource.com/c/tools/+/202480#message-fd2bcc0ec520a7fb71d5cc817f5addf0e2c7f85a> . After addressing review feedback, remember to publish your drafts <https://github.com/golang/go/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it> ! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#174?email_source=notifications&email_token=ANLNR2KZ7RN6IYAHIRI6GVDQPX36XA5CNFSM4JDDK7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB3NKUQ#issuecomment-544658770>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANLNR2PE4NH63THFSHSAYW3QPX36XANCNFSM4JDDK7LA> .

gopherbot · 2019-10-21T19:16:48Z

Message from Ian Cottrell:

Patch Set 1:

Nice!
I think the command should just be called fix, and in theory it should just apply "preferred" fixes by default, with flags that allow more fine grained control (along with maybe -all to just apply all fixes)

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

Add a flag for all fixes

gopherbot · 2019-10-21T19:47:25Z

This PR (HEAD: d344403) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/202480 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-21T19:51:28Z

Message from Kalman Bekesi:

Patch Set 2:

Patch Set 1:

Nice!
I think the command should just be called fix, and in theory it should just apply "preferred" fixes by default, with flags that allow more fine grained control (along with maybe -all to just apply all fixes)

Yeah, good idea. I've made the updates, although it does feel light on tests.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-21T19:52:29Z

Message from Kalman Bekesi:

Patch Set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:34:45Z

Message from Rebecca Stambler:

Patch Set 4: Run-TryBot+1 Code-Review+2

Thanks - this looks great! Agreed that we need some more tests, but unfortunately we don't have many suggested fixes (except for those in the opt-in tool staticcheck). You could enable staticcheck by adding "staticcheck": true as in https://golang.org/cl/202620 and add tests using the suggested fixes in staticcheck, if you'd like to. This can be done in a follow-up CL too.

Thank you for your contributions!

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:34:45Z

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=d0db29b5

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:37:44Z

Message from Gobot Gobot:

Patch Set 4:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/a754d299/freebsd-amd64-12_0_a323a16f.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:40:55Z

Message from Rebecca Stambler:

Patch Set 5: Patch Set 4 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:40:56Z

Message from Rebecca Stambler:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:40:56Z

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2f84b39f

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:43:04Z

Message from Gobot Gobot:

Patch Set 4: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:44:08Z

Message from Gobot Gobot:

Patch Set 5:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/a754d299/freebsd-amd64-12_0_2119ee0e.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:48:47Z

Message from Gobot Gobot:

Patch Set 5: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T04:54:51Z

Message from Rebecca Stambler:

Patch Set 5: -Run-TryBot

TryBot failures are unrelated - caused by golang/go#35226.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-29T08:38:51Z

This PR (HEAD: 070fcda) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/202480 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-30T23:11:17Z

Message from Rebecca Stambler:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-30T23:11:18Z

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=84f7b430

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-30T23:19:26Z

Message from Gobot Gobot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202480.
After addressing review feedback, remember to publish your drafts!

This adds support for calling suggestedfix from the gopls command line, e.g. $ gopls suggestedfix ~/tmp/foo/main.go Optional arguments are: -w, which writes the changes back to the original file; and -d, which prints a unified diff to stdout With no arguments, the changed files are printed to stdout. Wasn't sure if the command should be `suggestedfix` or just `fix` or `quickfix`? Also this applies all changes to a file, does not allow for selective fixes. Updates golang/go#32875 Change-Id: I8b75f9824be82974f6edb7c03383b4d56116943c GitHub-Last-Rev: 070fcda GitHub-Pull-Request: #174 Reviewed-on: https://go-review.googlesource.com/c/tools/+/202480 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

gopherbot · 2019-10-30T23:32:01Z

This PR is being closed because golang.org/cl/202480 has been merged.

kalmanb added 3 commits October 21, 2019 20:31

Add file Copyrights

c078249

Update error string

a0a0341

googlebot added the cla: yes label Oct 21, 2019

kalmanb added 2 commits October 21, 2019 21:42

Preferred fixes are now applied by default

79e10a4

Add a flag for all fixes

Rename from suggestedfix to fix

d344403

Fix spacing

070fcda

gopherbot closed this Oct 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools/gopls: add command line support for suggestedfix #174

tools/gopls: add command line support for suggestedfix #174

kalmanb commented Oct 21, 2019 •

edited

Loading

gopherbot commented Oct 21, 2019

gopherbot commented Oct 21, 2019

knight6782 commented Oct 21, 2019 via email

gopherbot commented Oct 21, 2019

gopherbot commented Oct 21, 2019

gopherbot commented Oct 21, 2019

gopherbot commented Oct 21, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

tools/gopls: add command line support for suggestedfix #174

tools/gopls: add command line support for suggestedfix #174

Conversation

kalmanb commented Oct 21, 2019 • edited Loading

gopherbot commented Oct 21, 2019

gopherbot commented Oct 21, 2019

knight6782 commented Oct 21, 2019 via email

gopherbot commented Oct 21, 2019

gopherbot commented Oct 21, 2019

gopherbot commented Oct 21, 2019

gopherbot commented Oct 21, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 29, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

gopherbot commented Oct 30, 2019

kalmanb commented Oct 21, 2019 •

edited

Loading