Skip to content

go/packages: Fix loading syntax for imports when types not requested. #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

go/packages: Fix loading syntax for imports when types not requested. #189

wants to merge 1 commit into from

Conversation

nevkontakte
Copy link
Contributor

http://golang.org/cl/205160 fixed an issue when package syntax wasn't
loaded unless NeedTypes was specified, but syntax of imported packages
wasn't loaded even with NeedDeps specified. This change corrects this
error.

Fixes issue #35331.

@gopherbot
Copy link
Contributor

This PR (HEAD: 56eba13) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/208597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@nevkontakte nevkontakte mentioned this pull request Nov 23, 2019
Closed
@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alex Zhirov:

Patch Set 1:

Thanks Michael for the review. If there are no issues to address in this CL, can it be merged?

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=94c2fb09

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 1:

yeah, could you rebase onto the top of the tree?

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/b234fdb5/freebsd-amd64-12_0_142c6130.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

8 of 10 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/b234fdb5/freebsd-amd64-12_0_142c6130.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/b234fdb5/linux-amd64_5d9fdadb.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/b234fdb5/linux-386_deb4665b.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/b234fdb5/windows-amd64-2016_06133f27.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/b234fdb5/openbsd-amd64-64_8791aa78.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/b234fdb5/windows-386-2008_0b3610bf.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/b234fdb5/linux-amd64-race_b4f9550a.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/b234fdb5/android-amd64-emu_a9a0e487.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@nevkontakte
go/packages: Fix loading syntax for imports when types not requested.
e81ddd0 
http://golang.org/cl/205160 fixed an issue when package syntax wasn't
loaded unless NeedTypes was specified, but syntax of imported packages
wasn't loaded even with NeedDeps specified. This change corrects this
error.

Fixes issue #35331.
@gopherbot
Copy link
Contributor

This PR (HEAD: e81ddd0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/208597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Alex Zhirov:

Patch Set 1:

Patch Set 1:

yeah, could you rebase onto the top of the tree?

Done.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 2: Run-TryBot+1

Ok, hopefully the trybots pass on the rebased commit.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=42063750

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/208597.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 20, 2019
@nevkontakte @matloob
go/packages: Fix loading syntax for imports when types not requested.
e5a4a00 
http://golang.org/cl/205160 fixed an issue when package syntax wasn't
loaded unless NeedTypes was specified, but syntax of imported packages
wasn't loaded even with NeedDeps specified. This change corrects this
error.

Fixes issue #35331.

Change-Id: If6d78f01eb59d406e44ab6746f2da9e797bbf8e2
GitHub-Last-Rev: e81ddd0
GitHub-Pull-Request: #189
Reviewed-on: https://go-review.googlesource.com/c/tools/+/208597
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/208597 has been merged.

@gopherbot gopherbot closed this Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nevkontakte @gopherbot @googlebot