Try to simplify goimports

[kamilsk]

Related to:

• Try to extend goimports #68
• internal/imports: force to repair imports group regardless of how the… #150

It tries to fix:

• x/tools/cmd/goimports: support repairing import grouping/ordering go#20818
• x/tools/cmd/goimports: adds flag control to delete extra blank lines before grouping go#43193

Appears in:

• x/tools/cmd/goimports: bad sorting cannot be fixed completely go#36140
• x/tools/cmd/goimports: Feature Request --> coalesce import groups go#35879

Example

the input

package testdata

import (
	_ "net"
	_ "encoding"

	_ "golang.org/x/mod/semver"

	_ "golang.org/x/sync/errgroup"

	_ "golang.org/x/tools/internal/imports"
)

Current behaviour

$ goimports testdata/example.go
package testdata

import (
        _ "encoding"
        _ "net"

        _ "golang.org/x/mod/semver"

        _ "golang.org/x/sync/errgroup"

        _ "golang.org/x/tools/internal/imports"
)

$ goimports -local golang.org/x/tools testdata/example.go
package testdata

import (
        _ "encoding"
        _ "net"

        _ "golang.org/x/mod/semver"

        _ "golang.org/x/sync/errgroup"

        _ "golang.org/x/tools/internal/imports"
)

$ goimports -local golang.org/x/tools,golang.org/x/mod testdata/example.go
package testdata

import (
        _ "encoding"
        _ "net"

        _ "golang.org/x/mod/semver"

        _ "golang.org/x/sync/errgroup"

        _ "golang.org/x/tools/internal/imports"
)

Patched behavior

$ ./patched testdata/example.go
package testdata

import (
        _ "encoding"
        _ "net"

        _ "golang.org/x/mod/semver"
        _ "golang.org/x/sync/errgroup"
        _ "golang.org/x/tools/internal/imports"
)

$ ./patched -local golang.org/x/tools testdata/example.go
package testdata

import (
        _ "encoding"
        _ "net"

        _ "golang.org/x/mod/semver"
        _ "golang.org/x/sync/errgroup"

        _ "golang.org/x/tools/internal/imports"
)

$ ./patched -local golang.org/x/tools,golang.org/x/mod testdata/example.go
package testdata

import (
	_ "encoding"
	_ "net"

	_ "golang.org/x/sync/errgroup"

	_ "golang.org/x/mod/semver"
	_ "golang.org/x/tools/internal/imports"
)

[gopherbot]

This PR (HEAD: f8c79ef) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/313090 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

This PR (HEAD: 1666f5c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/313090 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Heschi Kreinick:

Patch Set 2:

(1 comment)

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/313090.
After addressing review feedback, remember to publish your drafts!