go/analysis/passes/unusedresult: add test for typeparams #345

jmesyou · 2021-10-20T21:13:52Z

This CL adds a test for unused results inside a function using generics.

gopherbot · 2021-10-20T21:19:10Z

This PR (HEAD: ed4c84e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/357411 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-10-20T21:24:45Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-20T21:27:40Z

This PR (HEAD: d60ca4a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/357411 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-10-20T22:03:38Z

Message from Tim King:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-20T22:09:11Z

Message from Go Bot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-20T22:09:12Z

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/47f75dac-0179-464c-84a6-106cd4e67993

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-20T22:11:55Z

Message from kokoro:

Patch Set 2: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/47f75dac-0179-464c-84a6-106cd4e67993

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-20T22:23:20Z

Message from Go Bot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-25T15:57:31Z

Message from Robert Findley:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-25T17:30:35Z

Message from Tim King:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-26T20:22:41Z

This PR (HEAD: 0a69700) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/357411 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-10-26T20:25:58Z

Message from Jack You:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-26T21:46:17Z

Message from Tim King:

Patch Set 3:

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-27T20:23:23Z

This PR (HEAD: b7b4d46) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/357411 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-10-27T20:26:37Z

This PR (HEAD: b32146a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/357411 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-10-27T21:22:42Z

Message from Tim King:

Patch Set 5: Run-TryBot+1

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-27T21:22:43Z

Message from Go Bot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-27T21:22:44Z

Message from kokoro:

Patch Set 5:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/92b648f2-530f-44fc-9728-afc4c8c79fe2

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-27T21:22:45Z

Message from Go Bot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-27T21:22:45Z

Message from kokoro:

Patch Set 5: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/92b648f2-530f-44fc-9728-afc4c8c79fe2

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-27T21:22:46Z

Message from Go Bot:

Patch Set 5: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-27T21:22:47Z

Message from Jack You:

Patch Set 5:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T16:37:56Z

This PR (HEAD: 1379ff8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/357411 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-10-28T16:44:12Z

Message from Jack You:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T17:23:39Z

Message from Tim King:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T17:23:40Z

Message from Go Bot:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T17:23:41Z

Message from kokoro:

Patch Set 6:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/3c27cf98-4824-4e56-b5a7-e9b3cc57b86b

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T17:23:42Z

Message from kokoro:

Patch Set 6: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/3c27cf98-4824-4e56-b5a7-e9b3cc57b86b

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T17:23:43Z

Message from Go Bot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T17:32:49Z

Message from Tim King:

Patch Set 6: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T17:50:59Z

Message from Robert Findley:

Patch Set 6: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

This CL implements support for setting unused generic funcs via flags. A test for unused results with generics is added. Updates golang/go#48704

gopherbot · 2021-10-28T18:24:12Z

Message from Robert Findley:

Patch Set 6: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T18:24:12Z

Message from Robert Findley:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T18:24:13Z

Message from Tim King:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T18:24:14Z

Message from Tim King:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T18:24:15Z

Message from Jack You:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T18:24:31Z

This PR (HEAD: 1c6db19) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/357411 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-10-28T18:33:50Z

Message from Tim King:

Patch Set 7: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T18:39:56Z

Message from Go Bot:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-10-28T18:39:57Z

Message from kokoro:

Patch Set 7:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/c259e3c0-9bd3-4e3d-b599-0052c37748e4

Please don’t reply on this GitHub thread. Visit golang.org/cl/357411.
After addressing review feedback, remember to publish your drafts!

This CL adds a test for unused results inside a function using generics. Update golang/go#48704 Change-Id: I3703cd6bbc40142b4a667d3cd069ea0721a045ec GitHub-Last-Rev: 1c6db19 GitHub-Pull-Request: #345 Reviewed-on: https://go-review.googlesource.com/c/tools/+/357411 Reviewed-by: Tim King <taking@google.com> Run-TryBot: Tim King <taking@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Robert Findley <rfindley@google.com>

gopherbot · 2021-10-28T19:23:52Z

This PR is being closed because golang.org/cl/357411 has been merged.

google-cla bot added the cla: yes label Oct 20, 2021

jmesyou force-pushed the master branch from ed4c84e to d60ca4a Compare October 20, 2021 21:25

jmesyou force-pushed the master branch from d60ca4a to 0a69700 Compare October 26, 2021 20:14

jmesyou force-pushed the master branch from 0a69700 to b7b4d46 Compare October 27, 2021 20:22

jmesyou force-pushed the master branch from b7b4d46 to b32146a Compare October 27, 2021 20:24

jmesyou force-pushed the master branch from b32146a to 1379ff8 Compare October 28, 2021 16:37

go/analysis/passes/unusedresult: update and add test for typeparams

1c6db19

This CL implements support for setting unused generic funcs via flags. A test for unused results with generics is added. Updates golang/go#48704

jmesyou force-pushed the master branch from 1379ff8 to 1c6db19 Compare October 28, 2021 18:05

gopherbot closed this Oct 28, 2021

go/analysis/passes/unusedresult: add test for typeparams #345

go/analysis/passes/unusedresult: add test for typeparams #345

Conversation

jmesyou commented Oct 20, 2021

gopherbot commented Oct 20, 2021

gopherbot commented Oct 20, 2021

gopherbot commented Oct 20, 2021

gopherbot commented Oct 20, 2021

gopherbot commented Oct 20, 2021

gopherbot commented Oct 20, 2021

gopherbot commented Oct 20, 2021

gopherbot commented Oct 20, 2021

gopherbot commented Oct 25, 2021

gopherbot commented Oct 25, 2021

gopherbot commented Oct 26, 2021

gopherbot commented Oct 26, 2021

gopherbot commented Oct 26, 2021

gopherbot commented Oct 27, 2021

gopherbot commented Oct 27, 2021

gopherbot commented Oct 27, 2021

gopherbot commented Oct 27, 2021

gopherbot commented Oct 27, 2021

gopherbot commented Oct 27, 2021

gopherbot commented Oct 27, 2021

gopherbot commented Oct 27, 2021

gopherbot commented Oct 27, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021

gopherbot commented Oct 28, 2021