internal/jsonrpc2_v2: add sync.Once for "panic: close of closed channel" in idleListener.run #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el" in idleListener.run When timeout, closing timeout channel in idleListener.run may be called many times. I added sync.Once field to idleListner for preventing it. Fixes golang/go#51435
|
This PR (HEAD: 51f310c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/390194 to see it. Tip: You can toggle comments from me using the |
|
Message from Robert Findley: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/390194. |
|
Message from Bryan Mills: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/390194. |
|
This failure mode, along with a couple others, should be addressed more holistically by CL 388597. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When timeout, closing timeout channel in idleListener.run may be called many times.
I added sync.Once field to idleListner for preventing it.
Fixes golang/go#51435