-
Notifications
You must be signed in to change notification settings - Fork 2.3k
cmd/stringer: add the ability to optionally generate TypeFromString function #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/stringer: add the ability to optionally generate TypeFromString function #46
Conversation
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/129816. |
Message from Gerrit User 5065: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/129816. |
Message from Gerrit User 12446: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/129816. |
Message from Gerrit User 12446: Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2. Please don’t reply on this GitHub thread. Visit golang.org/cl/129816. |
Message from Gerrit User 5065: Patch Set 3: Maybe this should lazily populate the global maps with a sync.Once to not make golang/go#26775 worse. Please don’t reply on this GitHub thread. Visit golang.org/cl/129816. |
Message from Gerrit User 12446: Uploaded patch set 5: New patch set was added with same tree, parent, and commit message as Patch Set 4. Please don’t reply on this GitHub thread. Visit golang.org/cl/129816. |
88641d9
to
db1ebf7
Compare
8185551
to
dc03839
Compare
…o dev * commit '32f9afaadcc06d44f0bc2b73c03b2a2a09c0b80e': support scroll bar for graphviz
Message from Daniel Martí: Patch Set 5: Code-Review-2 I'm not sure why gobot pinged me now. In any case, I'm afraid that I proposed precisely this feature half a year before you posted this PR: golang/go#23535 It got rejected, so I think that's the end for now. I'm sorry that you spent the time to work on this patch, but in the future, please remember to raise an issue before working on a new feature. Please don’t reply on this GitHub thread. Visit golang.org/cl/129816. |
This PR is being closed because golang.org/cl/129816 has been abandoned. Clearing my incoming reviews queue. |
This PR adds the ability to generate function opposite to
String
allowing to retrieve type value by its string representation.