Skip to content

cmd/stringer: add the ability to optionally generate TypeFromString function #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bbrodriges
Copy link

This PR adds the ability to generate function opposite to String allowing to retrieve type value by its string representation.

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129816.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/129816.
After addressing review feedback, remember to publish your drafts!

@bbrodriges bbrodriges changed the title Allow stringer to optionally generate TypeFromString method cmd/stringer: add the ability to optionally generate TypeFromString function Aug 19, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129816.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129816.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 3:

Maybe this should lazily populate the global maps with a sync.Once to not make golang/go#26775 worse.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129816.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 5: New patch set was added with same tree, parent, and commit message as Patch Set 4.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129816.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 3 times, most recently from 88641d9 to db1ebf7 Compare October 4, 2019 03:45
@gopherbot gopherbot force-pushed the master branch 10 times, most recently from 8185551 to dc03839 Compare November 5, 2019 20:21
WenzheLiu pushed a commit to WenzheLiu/tools that referenced this pull request Dec 14, 2019
…o dev

* commit '32f9afaadcc06d44f0bc2b73c03b2a2a09c0b80e':
  support scroll bar for graphviz
@gopherbot
Copy link
Contributor

Message from Daniel Martí:

Patch Set 5: Code-Review-2

I'm not sure why gobot pinged me now.

In any case, I'm afraid that I proposed precisely this feature half a year before you posted this PR: golang/go#23535

It got rejected, so I think that's the end for now. I'm sorry that you spent the time to work on this patch, but in the future, please remember to raise an issue before working on a new feature.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129816.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/129816 has been abandoned.

Clearing my incoming reviews queue.

@gopherbot gopherbot closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants