gopls: implement code action to split/group lines #470

fatanugraha · 2024-01-25T13:07:57Z

Implement a code action to easily refactor function arguments, return
values, and composite literal elements into separate lines or a single
line.

This feature would be particularly helpful when working on large
business-related features that often require long variable names.
The ability to quickly split or group lines would significantly
accelerate refactoring efforts to ensure code adheres to specified
character limits.

Fixes golang/go#65156

gopherbot · 2024-01-25T13:19:38Z

This PR (HEAD: 1e8d4a3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/558475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-25T13:27:03Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-25T13:49:01Z

Message from Fata Nugraha:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-26T19:49:11Z

Message from Robert Findley:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-26T20:07:30Z

Message from Alan Donovan:

Patch Set 2:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

Address comments Add comment Add comment Simplify comment

gopherbot · 2024-02-03T23:57:05Z

This PR (HEAD: 99a6184) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/558475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-04T00:02:51Z

Message from Fata Nugraha:

Patch Set 2:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-04T00:08:39Z

Message from Gopher Robot:

Patch Set 3:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-04T16:55:37Z

Message from Alan Donovan:

Patch Set 3:

(28 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-17T17:07:46Z

This PR (HEAD: b31e645) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/558475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-17T17:14:17Z

Message from Fata Nugraha:

Patch Set 3:

(28 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-17T17:20:26Z

This PR (HEAD: 34b3199) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/558475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T20:14:43Z

Message from Alan Donovan:

Patch Set 5: Code-Review+2

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T22:04:30Z

This PR (HEAD: dff8ef3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/558475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-23T22:22:27Z

Message from Fata Nugraha:

Patch Set 5:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T22:22:32Z

This PR (HEAD: bb36847) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/558475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-26T14:41:24Z

Message from Robert Findley:

Patch Set 7: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T14:48:06Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-26T14:33:01Z","revision":"308bb83be5f1dfffe740959b81e329872740b985"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T14:48:07Z

Message from Robert Findley:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T14:48:08Z

Message from Go LUCI:

Patch Set 7:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-go1.19-linux-amd64 has failed with summary (view all results):

FAILURE

go on release-branch.go1.19 (commit 619b8fd)
tools on master (change 558475)

Error:
failed to run "test golang.org/x/tools/gopls module": exit status 1

Links:

"test golang.org/x/tools/gopls module" (combined output)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T14:48:08Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T18:29:53Z

Message from Alan Donovan:

Patch Set 7: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-26T18:29:53Z

Message from Robert Findley:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T13:04:38Z

This PR (HEAD: d3c5b57) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/558475.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-27T13:11:11Z

Message from Fata Nugraha:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T14:44:19Z

Message from Alan Donovan:

Patch Set 8: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T14:44:20Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-27T14:36:12Z","revision":"2e6c7fd90253ce9bd0b8f613cb78ed3d37a16caa"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T14:44:20Z

Message from Robert Findley:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/558475.
After addressing review feedback, remember to publish your drafts!

Implement a code action to easily refactor function arguments, return values, and composite literal elements into separate lines or a single line. This feature would be particularly helpful when working on large business-related features that often require long variable names. The ability to quickly split or group lines would significantly accelerate refactoring efforts to ensure code adheres to specified character limits. Fixes golang/go#65156 Change-Id: I00aaa1377735f14808424e8e99fa0b7eeab90a7a GitHub-Last-Rev: d3c5b57 GitHub-Pull-Request: #470 Reviewed-on: https://go-review.googlesource.com/c/tools/+/558475 Reviewed-by: Alan Donovan <adonovan@google.com> Auto-Submit: Alan Donovan <adonovan@google.com> Reviewed-by: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2024-02-27T14:57:42Z

This PR is being closed because golang.org/cl/558475 has been merged.

fatanugraha and others added 7 commits February 4, 2024 02:41

Implement line group/split

ca461f0

Address comments Add comment Add comment Simplify comment

Fix test

a0db357

Handle /*-style comment properly

7811637

Fix checker logic to only capture the first enclosing paren

a52609e

Do not suggest code action if it has comment in it and elts <= 1

ecfda52

Fix comment

306c61a

Merge branch 'golang:master' into master

99a6184

Address review comments

d4697e6

Rename to join

34b3199

Merge branch 'golang:master' into master

dff8ef3

Address comment

bb36847

Use internal slice

d3c5b57

gopherbot closed this Feb 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gopls: implement code action to split/group lines #470

gopls: implement code action to split/group lines #470

fatanugraha commented Jan 25, 2024 •

edited

Loading

gopherbot commented Jan 25, 2024

gopherbot commented Jan 25, 2024

gopherbot commented Jan 25, 2024

gopherbot commented Jan 26, 2024

gopherbot commented Jan 26, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 4, 2024

gopherbot commented Feb 4, 2024

gopherbot commented Feb 4, 2024

gopherbot commented Feb 17, 2024

gopherbot commented Feb 17, 2024

gopherbot commented Feb 17, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopls: implement code action to split/group lines #470

gopls: implement code action to split/group lines #470

Conversation

fatanugraha commented Jan 25, 2024 • edited Loading

gopherbot commented Jan 25, 2024

gopherbot commented Jan 25, 2024

gopherbot commented Jan 25, 2024

gopherbot commented Jan 26, 2024

gopherbot commented Jan 26, 2024

gopherbot commented Feb 3, 2024

gopherbot commented Feb 4, 2024

gopherbot commented Feb 4, 2024

gopherbot commented Feb 4, 2024

gopherbot commented Feb 17, 2024

gopherbot commented Feb 17, 2024

gopherbot commented Feb 17, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 26, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 27, 2024

fatanugraha commented Jan 25, 2024 •

edited

Loading