Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: provide an option to auto-update dlv-dap #1404

Closed
hyangah opened this issue Apr 7, 2021 · 1 comment
Closed

debug: provide an option to auto-update dlv-dap #1404

hyangah opened this issue Apr 7, 2021 · 1 comment
Assignees
@suzmue
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge tools/installation
Milestone
v0.25.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 7, 2021

Currently we are prompting users to update dlv-dap when we find the binary is outdated.
Actual update happens only when users click the button on the prompt message or install using Go: Install/Update Tools command. We plan to update the required dlv-dap version ideally every time we release a new golang.go extension so that may be annoying. Provide an option for auto-update (in a similar way gopls does).

@suzmue @polinasok
@hyangah hyangah added Debug Issues related to the debugging functionality of the extension. DlvDAP labels Apr 7, 2021
@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@hyangah hyangah modified the milestones: Untriaged, Backlog Apr 14, 2021
@suzmue suzmue self-assigned this Apr 14, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/310183 mentions this issue: src/goDebugConfiguration: auto update dlv-dap if autoUpdates enabled

gopherbot pushed a commit that referenced this issue Apr 15, 2021
@suzmue
src/goDebugConfiguration: auto update dlv-dap if autoUpdates enabled
86f704a 
If go.toolsManagement["autoUpdate"] is true, then the user wants the
extension to autoupdate their tools, so we can do this without
prompting first and continue with the debug session.

If we think more people may want to autoUpdate *only* dlv-dap, we can
add an additional setting to control dlv-dap and the prompt.

Updates #1404

Change-Id: I5b249e483a6b3b06cf6f8ef851836c0a88803954
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/310183
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@suzmue suzmue closed this as completed Apr 19, 2021
@suzmue suzmue modified the milestones: Backlog, v0.25.0 Apr 19, 2021
@golang golang locked and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@suzmue suzmue

Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge tools/installation
Projects
None yet
Milestone
v0.25.0
Development

No branches or pull requests
3 participants
@hyangah @suzmue @gopherbot