-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopls: add documentation and warnings about ignored settings #155
Labels
Milestone
Comments
Change https://golang.org/cl/273146 mentions this issue: |
Change https://golang.org/cl/273147 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Dec 3, 2020
For #155 Change-Id: I4efca525ea83c19ec4ed1a0949d76d104f3fd701 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/273147 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
gopherbot
pushed a commit
that referenced
this issue
Dec 21, 2020
They are passed as gopls.buildFlags only if gopls.buildFlags isn't already explicitly set - users have to use JSON-based UI and add the fields (including []). If go.buildFlags has -tags, go.buildTags is ignored, which is consistent with the extension's build behavior coded in goBuild (goBuild.ts). For #155 Change-Id: I03d5f5eb58d049454fb4a66d902a7daea4a1269f Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/273146 Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Suzy Mueller <suzmue@golang.org> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Suzy Mueller <suzmue@golang.org>
Change https://golang.org/cl/279419 mentions this issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See the original discussion at microsoft/vscode-go#2965.
A number of VS Code Go settings, including
"go.buildTags"
are ignored when used withgopls
. We should either propagate these settings or offer a warning that they are being ignored.The text was updated successfully, but these errors were encountered: