Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to disable the "your ... is different than before" messages #1698

Closed
zikaeroh opened this issue Aug 17, 2021 · 4 comments
Closed
Assignees
Milestone

Comments

@zikaeroh
Copy link

Is your feature request related to a problem? Please describe.

I'm working on both the Go toolchain and my own projects. To work in the Go repo, you need to use the version of Go being edited in order for things to work. Every time I open a project, I get a popup that tells me that my Go version has changed and that I should be recompiling my tools. I know that I don't (since I use gopls, and manage my installed tools pretty carefully), so this message doesn't really help me, and I'd like to be able to hide these messages.

Describe the solution you'd like

Some sort of option to disable the notification, or any and all of tools checks (as I manage them myself).

Describe alternatives you've considered

VS Code doesn't have a way to block the messages for an extension, so that isn't an option, and there's no away around the checks at the moment. I have both:

"go.toolsManagement.checkForUpdates": "off",
"go.toolsManagement.autoUpdate": false,

But these don't get rid of everything.

Additional context

N/A

@gopherbot gopherbot added this to the Untriaged milestone Aug 17, 2021
@stamblerre stamblerre modified the milestones: Untriaged, Backlog Aug 17, 2021
@hyangah hyangah modified the milestones: Backlog, v0.28.0 Aug 20, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/349752 mentions this issue: src/goMain: remove tools version check hack

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/349953 mentions this issue: [release] src/goMain: remove tools version check hack

@hyangah
Copy link
Contributor

hyangah commented Sep 14, 2021

We found this check is now too inaccurate to be useful.
In v0.28.0, we will remove this check. From cl/349742 description ---

The existing tool version checks in suggestUpdates simply compare
the go version & GOROOT/GOPATH used with the tool last time. That is
a hack added when there was no good way to check tool's exact versions
and users organize compatible tools using GOPATH.

Now many of recent tools (e.g. gopls) do not depend on hardcoded
GOROOT or the go version used while compiling the tools. It's still
desirable to compile tools with the latest version of go but the
go version does not have to match exactly with the go version
used to compile the tools. For example, tools compiled with go1.16
can be used to work with go1.16.1 or go1.15.

Now Go is released frequently, and the extension allows users to
switch between different go versions more easily, this incorrect
popup is often annoying and confuses users, than helping users
stay up-to-date with latest tools. Remove this incorrect heuristic
for now.

@zikaeroh
Copy link
Author

Thank you!

gopherbot pushed a commit that referenced this issue Sep 14, 2021
The existing tool version checks in suggestUpdates simply compare
the go version & GOROOT/GOPATH used with the tool last time. That is
a hack added when there was no good way to check tool's exact versions
and users organize compatible tools using GOPATH.

Now many of recent tools (e.g. gopls) do not depend on hardcoded
GOROOT or the go version used while compiling the tools. It's still
desirable to compile tools with the latest version of go but the
go version does not have to match exactly with the go version
used to compile the tools. For example, tools compiled with go1.16
can be used to work with go1.16.1 or go1.15.

Now Go is released frequently, and the extension allows users to
switch between different go versions more easily, this incorrect
popup is often annoying and confuses users, than helping users
stay up-to-date with latest tools. Remove this incorrect heuristic
for now.

Updates #487
Fixes #1698

Change-Id: I7a7c6a0d654ae080ea2bd221a366230ebb98bb7e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/349752
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
(cherry picked from commit 23a2db0)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/349953
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Trust: Suzy Mueller <suzmue@golang.org>
@golang golang locked and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants