Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: "Pause on breakpoint" is shown when pausing with "Pause (F6)" #172

Closed
hyangah opened this issue Jun 4, 2020 · 4 comments
Closed

debug: "Pause on breakpoint" is shown when pausing with "Pause (F6)" #172

hyangah opened this issue Jun 4, 2020 · 4 comments
Assignees
@polinasok
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Milestone
vscode-go/unplanned

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 4, 2020

Originally reported in microsoft/vscode-go#3158.

When pausing the program with no breakpoints set with Pause F6, I see the UI say "paused on breakpoint" some of the times. I expect to see "paused on pause".
See the analysis @polinasok posted in the original report.

This is reproducible with Nightly & Insiders.
@hyangah hyangah mentioned this issue Jun 4, 2020
Closed
@stamblerre stamblerre added the Debug Issues related to the debugging functionality of the extension. label Jun 4, 2020
@polinasok polinasok mentioned this issue Sep 3, 2020
Closed
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/253578 mentions this issue: src/debugAdapter: send stopped events from continue on breakpoint only

gopherbot pushed a commit that referenced this issue Sep 15, 2020
@suzmue
src/debugAdapter: send stopped events from continue on breakpoint only
9a2bc10 
The callback function for continue assumed that the reason the callback
was called was a breakpoint. However, a pause or disconnection also result
in the continue callback being called.

This change checks to see if the current thread is stopped on a
breakpoint, and will only stop the threads and notify the client if
this is true.

Fixes #149 and #172

Change-Id: Ic9c747db4cac136828d3879bbd95c2e00fe84659
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/253578
Trust: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Polina Sokolova <polina@google.com>
@suzmue
Copy link
Contributor

suzmue commented Sep 17, 2020

Fixed by cl/253578

@suzmue suzmue closed this as completed Sep 17, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/262257 mentions this issue: src/debugAdapter: revert cl/253578

gopherbot pushed a commit that referenced this issue Oct 14, 2020
@suzmue
src/debugAdapter: revert cl/253578
6703469 
There were some issues caused by not sending a stopped event to
the client every time that the continue callback was called. This
change reverts the logic to skip calling handleReenterDebug in
order to get back to a state where the debugger issues stopped events
every time. This should fix issues with the debugger appearing to
be running when it is stopped.

Updates #149, #172, and #759

Change-Id: I70aae05bc3bf50499b046594a43d972ec01091cf
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/262257
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Trust: Suzy Mueller <suzmue@golang.org>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@suzmue suzmue reopened this Oct 14, 2020
@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@hyangah hyangah modified the milestones: Untriaged, Backlog Apr 14, 2021
@suzmue
Copy link
Contributor

suzmue commented May 26, 2021

This is fixed in the new debug adapter.

We do not intend to fix this in the legacy adapter, as it is very fragile.

@suzmue suzmue closed this as completed May 26, 2021
@golang golang locked and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@polinasok polinasok

Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Milestone
vscode-go/unplanned
Development

No branches or pull requests
5 participants
@hyangah @stamblerre @suzmue @gopherbot @polinasok