Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt pre-release extension support #1935

Closed
isidorn opened this issue Dec 9, 2021 · 11 comments
Closed

Adopt pre-release extension support #1935

isidorn opened this issue Dec 9, 2021 · 11 comments
Milestone
v0.44.0

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 9, 2021

Hi VS Code PM here 👋

Refs: microsoft/vscode#15756

VS Code now supports pre-release extensions. Docs that should help: https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions

I know GO has a separate Go Nightly. Ideally Go would adopt to our pre-release support and we would deprecate that extension. VS Code can automatically migrate your existing Go Nightly users to the pre-release version of the Go extension once you have done the adoption.

Let me know what you think
@gopherbot gopherbot added this to the Untriaged milestone Dec 9, 2021
@hyangah
Copy link
Contributor

hyangah commented Dec 9, 2021

That's a great news!
Thanks @isidorn for keeping us posted.

@hyangah hyangah modified the milestones: Untriaged, On Deck Dec 9, 2021
@hyangah hyangah added NeedsFix The path to resolution is known, but the work has not been done. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Dec 9, 2021
@hyangah hyangah mentioned this issue Jan 5, 2021
Closed
@isidorn
Copy link
Contributor Author

isidorn commented Jul 3, 2023

Friendly ping for this. Go is the only remaining extension in the VS Code ecosystem that is using nightly.
Can you migrate to pre-release? Are there some blockers? Thanks 🙏

@hyangah hyangah modified the milestones: vscode-go/backlog, v0.43.0 Jul 15, 2024
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/595381 mentions this issue: extension/tools/release: handle prerelease versions

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/595380 mentions this issue: extension/tools/release: use v0.43.0 and v0.44.0 in testing

@isidorn
Copy link
Contributor Author

isidorn commented Jul 25, 2024

Once this is done just ping me and we can migrate users from your Nightly extension to the pre-release version.

gopherbot pushed a commit that referenced this issue Aug 8, 2024
@hyangah
extension/tools/release: use v0.43.0 and v0.44.0 in testing
6bafa62 
The next change implements prerelease version package/publish
steps. We use odd minor version number for prerelease, and
while minor version number for stable release.

Update the test dataset to use v0.43.0 and v0.44.0 instead of
v0.0.0. So, in the next change, the diff presents
the difference between prerelease vs stable release clearly.

We keep release candidate version handling for now. So, we can still
create a release candidate version before the stable release.
After we are confident about the updated release process, we can
think about skipping the release candidate creation step in favor
of prerelease versions.

For #1935

Change-Id: Ie88cd7932abb992fcb0b2a925b7c69de84d946ba
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/595380
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopherbot pushed a commit that referenced this issue Aug 8, 2024
@hyangah
extension/tools/release: handle prerelease versions
c086dbb 
From v0.43+, we will use the prerelease extension.

Odd number minor version indicates prerelease.
Even number minor versions are for stable release.

Prerelease is done by pass --pre-release flag when running
vsce package & vsce publish commands.

https://code.visualstudio.com/api/working-with-extensions/publishing-extension#prerelease-extensions

For #1935

Change-Id: Ib2a2aeabe588dcefd79f1b7fe8bc4aa46871373d
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/595381
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Aung Ko <aungko.use@gmail.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/595382 mentions this issue: src/config: set ExtensionInfo.isPreview for prerelease

gopherbot pushed a commit that referenced this issue Aug 20, 2024
@hyangah
src/config: set ExtensionInfo.isPreview for prerelease
a83a369 
Odd number minor version implies prerelease.

For #1935

Change-Id: I6cf4c4673b3a70609c45a17ce7ee0b92dca6ce5b
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/595382
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
@hyangah hyangah mentioned this issue Aug 21, 2024
Closed
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/607756 mentions this issue: extension: stop setting "preview" for v0.43.0

gopherbot pushed a commit that referenced this issue Aug 22, 2024
@hyangah
extension: stop setting "preview" for v0.43.0
9d62506 
v0.43.0 is our first pre-release version that replaces
the nightly extension. Pre-release is built from the master
branch. Previously we set the preview' field because
the nightly extension is built from the master and
golang.go-nightly is a preview extension in our
definition. golang.go is not a preview extension
so let's unset this field.

Nightly extension publishing is paused.

And add a CHANGELOG entry for v0.43.0.
For pre-release versions, we will skip CHANGELOG addition.
But, it's good to announce the first pre-release version
and mention the deprecation of nightly.

For #1935

Change-Id: I326963818aa3bd7723bbdf69d5b747f57210b5c1
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/607756
Reviewed-by: Robert Findley <rfindley@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
@hyangah
Copy link
Contributor

hyangah commented Aug 26, 2024

Our first insider version (v0.43.0) is published.
Nightly extension publication is stopped.

@isidorn Can you please migrate the nightly extension users? Thanks!

@isidorn
Copy link
Contributor Author

isidorn commented Aug 30, 2024

Thanks for the ping. Will do the migration later today/Monday. And deprecate the nightly one.

@hyangah hyangah modified the milestones: v0.43.0, v0.44.0 Aug 30, 2024
@hyangah
Copy link
Contributor

hyangah commented Sep 4, 2024

Thanks @isidorn for your patience and help!
Verified the nightly is deprecated. It's still active in the marketplace, but I guess the change eventually will apply there too :-)

Screenshot 2024-09-04 at 3 47 41 PM

@hyangah hyangah closed this as completed Sep 4, 2024
@hyangah hyangah removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 4, 2024
@isidorn
Copy link
Contributor Author

isidorn commented Sep 5, 2024

Marketplace does not support deprecated extensions (yet).
So I think we are good. Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.44.0
Development

No branches or pull requests
3 participants
@isidorn @hyangah @gopherbot