Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: properly declare gopls related settings #197

Closed
hyangah opened this issue Jun 9, 2020 · 4 comments
Closed

settings: properly declare gopls related settings #197

hyangah opened this issue Jun 9, 2020 · 4 comments
Assignees
@hyangah
Labels
FrozenDueToAge
Milestone
v0.20.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 9, 2020

Since gopls is in alpha and the set of final flags and configurable parameters are not finalized, we are still relying on the gopls object that is not officially declared. As gopls development becomes stable, we need to sort out settings and properly declare it.

Related: for VS Code UI feature to utilize - microsoft/vscode#99635
Related: for automatic generation of docs (possibly, part of package.json) - https://go-review.googlesource.com/c/tools/+/212521

@stamblerre
This was referenced Jun 12, 2020
Closed
Closed
@hyangah hyangah mentioned this issue Aug 20, 2020
Closed
@macintacos macintacos mentioned this issue Sep 9, 2020
Closed
@stamblerre
Copy link
Contributor

It should now be possible to do this after CL 252322, using the settings JSON. The JSON for commands still needs to be generated.

/cc @heschik

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/265742 mentions this issue: package.json: embed autogenerated gopls settings

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/265741 mentions this issue: tools/goplssetting: command to autogenerate gopls settings

@stamblerre stamblerre mentioned this issue Nov 16, 2020
Closed
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/270803 mentions this issue: package.json: embed autogenerated gopls settings

gopherbot pushed a commit that referenced this issue Nov 17, 2020
@hyangah
tools/goplssetting: command to autogenerate gopls settings
da36eb1 
The tool runs `gopls api-json`, converts the result to vscode setting
formats, and updates vscode-go package.json.

Note: `gopls api-json` requires gopls v0.5.2+.

For #197

Change-Id: Idfca4e899d658b1647d6fedde4b3cb0343eeae30
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/265741
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
gopherbot pushed a commit that referenced this issue Nov 17, 2020
@hyangah
tools/generate.go: recognize markdownDescription field
68a73a6 
`markdownDescription` field will be used by all the gopls properties.

For #197

Change-Id: I5c4dec896e52f0520f81dd7d857fa876943de6ca
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/265742
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@hyangah hyangah modified the milestones: v0.19.0, v0.20.0 Nov 17, 2020
@hyangah hyangah self-assigned this Nov 20, 2020
@hyangah hyangah modified the milestones: v0.21.0, v0.20.0 Dec 14, 2020
@golang golang locked and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hyangah hyangah

Labels
FrozenDueToAge
Projects
None yet
Milestone
v0.20.0
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot