Reevaluate the need for tools reinstallations when GOROOT is changed

[hyangah]

This extension keeps track of the GOROOT used last time in ctx.globalState.get('toolsGoInfo').
If use of a different GOROOT is detected when activated, it prompts users to recompile/reinstall Go tools with a message like:

Your current goroot (${currentGoroot}) is different than before (${prevGoroot}), a few Go tools may need recompiling

The code is here

vscode-go/src/goMain.ts

Lines 94 to 127 in 89c61d9

	if (prevGoroot && prevGoroot.toLowerCase() !== currentGoroot) {
	vscode.window
	.showInformationMessage(
	`Your current goroot (${currentGoroot}) is different than before (${prevGoroot}), a few Go tools may need recompiling`,
	updateToolsCmdText
	)
	.then((selected) => {
	if (selected === updateToolsCmdText) {
	installAllTools(true);
	}
	});
	} else {
	const currentVersion = await getGoVersion();
	if (currentVersion) {
	const prevVersion = toolsGoInfo[toolsGopath].version;
	const currVersionString = currentVersion.format();
	if (prevVersion !== currVersionString) {
	if (prevVersion) {
	vscode.window
	.showInformationMessage(
	'Your Go version is different than before, a few Go tools may need re-compiling',
	updateToolsCmdText
	)
	.then((selected) => {
	if (selected === updateToolsCmdText) {
	installAllTools(true);
	}
	});
	}
	toolsGoInfo[toolsGopath].version = currVersionString;
	}
	}
	}

This was a heuristic to deal with old tools that used the GOROOT embedded during the tool's compile time (See microsoft/vscode-go#1286 for example) in old days. Newer tools shouldn't depend on the value of GOROOT used in the tool's compile time, so recompiling shouldn't be necessary as long as the tool is up-to-date.

Examine tools this extension depends on and check whether they use hard-coded build time GOROOT.
Once we know no tools require recompilation any more, remove this popup and the heuristic.

Inspection status (check if investigated && not require recompilation)

• gocode
• gocode-gomod
• gopkgs: uses build.Default.GOROOT, requires to set the GOROOT env var.
• go-outline
• go-symbols
• guru
• gorename
• gomodifytags
• goplay
• impl
• gotype-live
• godef: works, but requires to set the GOROOT env var.
• gogetdoc
• goimports
• goreturns
• goformat
• golint
• gotests
• staticcheck: no issue with the latest version.
• golangci-lint
• revive
• gopls
• dlv
• fillstruct
• godoctor

cc @stamblerre @mcjcloud @FiloSottile

[gopherbot]

Change https://golang.org/cl/244758 mentions this issue: src/goDeclaration.ts: godef requires the right GOROOT env var

[hyangah]

A user reported gocode (or gocode-gomod) needed to be reinstalled when go is updated. (#552) Need to verify it.

[gopherbot]

Change https://golang.org/cl/254137 mentions this issue: src/goPackages.ts: pass GOROOT to gopkgs

[hyangah]

The mentioned code that tracks GOROOT change was deleted. Instead, the extension currently checks go version output and compares the tools' build info (go version -m) since v0.32.0 So, I'd say this issue is no longer relevant.
Closing this issue.