debug: require a dev version of delve when operating in Delve DAP mode #794
Comments
hyangah
added
the
Debug
|
According to @aarzilli, delve "makes one release roughly every 6 months around the time when Go rc1 comes out." Middway releases happen, but are not guaranteed. So to be able to pick up new changes for the new experimental adapter quickly, we definitely need to pin to more recent dev versions, i.e. picking specific commits we like. |
|
Another thought. Since users might be switching between stable and experimental adapters, we should be careful not to wipe out stable delve to be used with the stable adapter with some recent experimental commit. There should be two separate delve binaries. |
|
Change https://golang.org/cl/297189 mentions this issue: |
|
Change https://golang.org/cl/297190 mentions this issue: |
|
@suzmue found an issue with the first installation and is preparing a fix for this in https://go-review.googlesource.com/c/vscode-go/+/303235 |
Preparation for https://go-review.googlesource.com/c/vscode-go/+/297189/ Updates #794 Change-Id: I4f83911f6e5304f6bb2e470f79caa7578e40742d Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/297190 Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Suzy Mueller <suzmue@golang.org>
dlv-dap needs to appear in the list of missing tools in order for the user get the prompt to install. Additionally, if they already have dlv-dap installed, we do want dlv-dap to appear as a tool to update, since we are building from master. If the user has declined to install, do not attempt to prompt, because it will do nothing. Instead, continue with the debugging session without attempting to install so the error will show up later. Updates #794 Change-Id: If5922c950fde621d4c666e06bcc149413674ed9d Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/303235 Trust: Suzy Mueller <suzmue@golang.org> Run-TryBot: Suzy Mueller <suzmue@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
|
Change https://golang.org/cl/303235 mentions this issue: |
Delve DAP is under active development. Many new features and bug fixes the Delve DAP adapter
depends on will be most likely not available with the stable version of Delve.
Pin required versions with extension release, and ask for update when Delve DAP adapter is used
and the current delve version is older than the required version.
@suzmue @polinasok
Related: #487
The text was updated successfully, but these errors were encountered: