Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: welcome page #949

Closed
hyangah opened this issue Nov 20, 2020 · 4 comments
Closed

ui: welcome page #949

hyangah opened this issue Nov 20, 2020 · 4 comments
Assignees
@stamblerre @suzmue
Labels
FeatureRequest FrozenDueToAge
Milestone
v0.22.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Nov 20, 2020

We want to have a welcome page that highlights

  • Notable changes in the version (including images)
  • Settings guide
  • Links to the helpful external resources
    - Documentation (features, settings, commands, debugging, outstanding issues)
    - Go tutorials (modules, command, go.dev)
    - Issue tracker
    - Community

VSCode team is currently working on a UI/API common across all extensions (microsoft/vscode#102139) but we may want more customization and richer UI.

Some inspirational work to check out:
https://github.com/alefragnani/vscode-whats-new
https://github.com/eamodio/vscode-gitlens/blob/b0fab09dd9325228ba0a1f602f27aff0fca1f484/src/webviews/welcomeWebview.ts
Google Cloud Code welcome/main pages.
@hyangah
Copy link
Contributor Author

hyangah commented Nov 20, 2020

When we turn on gopls, I hope this page helps surface this change clearly.

@hyangah hyangah added this to the v0.20.0 milestone Nov 20, 2020
@stamblerre stamblerre self-assigned this Nov 24, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/280596 mentions this issue: src/welcome.ts: add welcome webview

gopherbot pushed a commit that referenced this issue Jan 7, 2021
@suzmue
src/welcome.ts: add welcome webview
197bec6 
This change is the initial change for adding a welcome page
for the extension. This adds the basic structure and a link to
open the release notes, which uses the communication channel
between the webview and the extension.

The webview is based on the microsoft webview example:
https://github.com/microsoft/vscode-extension-samples/tree/master/webview-sample

Updates #949

Change-Id: I08f63346781dcf9afb24b8d482394a0db7cf6492
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/280596
Trust: Suzy Mueller <suzmue@golang.org>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@hyangah
Copy link
Contributor Author

hyangah commented Jan 15, 2021

The mechanism for the welcome webview is available in v0.21.0, but we will not prompt it during activation in this version.
We will use it in v0.22.0 release.

@hyangah hyangah modified the milestones: v0.21.0, v0.22.0 Jan 15, 2021
@hyangah
Copy link
Contributor Author

hyangah commented Jan 25, 2021

This is done.
According to https://code.visualstudio.com/api/references/extension-guidelines, we will consider moving and extending this to Welcome View (https://code.visualstudio.com/api/references/extension-guidelines#welcome-views).

@hyangah hyangah closed this as completed Jan 25, 2021
@golang golang locked and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stamblerre stamblerre

@suzmue suzmue

Labels
FeatureRequest FrozenDueToAge
Projects
None yet
Milestone
v0.22.0
Development

No branches or pull requests
4 participants
@hyangah @stamblerre @suzmue @gopherbot