src/goTestExplorer: implement a test provider for the new test api #1590

firelizzard18 · 2021-06-25T04:13:39Z

What this does:

Implements a test provider using the new API
Populates the test explorer with a list of modules and/or workspaces
Populates each module/workspace/package/file as it is expanded
Creates test entries for the current file, and package/module parents
Runs tests!

What this does not:

Debug tests
Handle stretchr suites

Issues:

Handling of benchmarks isn't great. But I'm not sure it can get much
better without changes to go test.
If a test has subtests, I add those subtests. This can get annoying if
you have a bunch of subtests. Should this be configurable? Disabling
testing.followRunningTest can improve this UX.

Fixes #1579

google-cla · 2021-06-25T04:14:07Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

firelizzard18 · 2021-06-25T04:16:07Z

@googlebot I signed it!

gopherbot · 2021-06-25T04:20:29Z

This PR (HEAD: ccb25a9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-06-25T04:24:51Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-25T06:48:08Z

This PR (HEAD: 6cf3c3d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-06-25T08:42:36Z

This PR (HEAD: 73f15b3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-06-25T19:21:31Z

Message from Suzy Mueller:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-25T19:39:07Z

Message from Ethan Reesor:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-25T23:57:30Z

This PR (HEAD: ef064dc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-06-26T01:34:07Z

Message from Suzy Mueller:

Patch Set 8: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-26T01:40:16Z

Message from kokoro:

Patch Set 8:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/103091b8-b5ab-48a9-8a78-8c771603c6a0

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-26T01:44:46Z

Message from kokoro:

Patch Set 8: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/103091b8-b5ab-48a9-8a78-8c771603c6a0

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-26T01:59:31Z

This PR (HEAD: 1ee5851) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-06-30T21:09:45Z

Message from Suzy Mueller:

Patch Set 9: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-30T21:12:10Z

Message from kokoro:

Patch Set 9:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/4e37bc7d-ed07-4f14-ac67-e61c38d61de4

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-30T21:19:16Z

Message from kokoro:

Patch Set 9: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/4e37bc7d-ed07-4f14-ac67-e61c38d61de4

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-06-30T23:16:31Z

Message from Ethan Reesor:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-08T15:39:24Z

Message from Suzy Mueller:

Patch Set 9:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-08T22:11:53Z

This PR (HEAD: 77f3623) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-08T22:18:33Z

Message from Ethan Reesor:

Patch Set 10:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T01:16:51Z

This PR (HEAD: 24faa6b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-09T01:19:04Z

Message from Ethan Reesor:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T07:35:16Z

This PR (HEAD: ee4a140) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-09T07:39:59Z

Message from Ethan Reesor:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/330809.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T18:43:48Z

This PR (HEAD: 305f2c3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/330809 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Change function names and add comments.

Fix a dumb mistake and remove a TODO.

What this does: - Implements a test provider using the new API - Populates the test explorer with a list of modules and/or workspaces - Populates each module/workspace/package/file as it is expanded - Creates test entries for the current file, and package/module parents - Runs tests! What this does not: - Debug tests - Handle stretchr suites Issues: - Handling of benchmarks isn't great. But I'm not sure it can get much better without changes to `go test`. - If a test has subtests, I add those subtests. This can get annoying if you have a bunch of subtests. Should this be configurable? Disabling `testing.followRunningTest` can improve this UX. Fixes #1579 Change-Id: I027c7c3b615eda4c528da9739520e6bfd1aa6911 GitHub-Last-Rev: 59af29b GitHub-Pull-Request: #1590 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/330809 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Suzy Mueller <suzmue@golang.org>

google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Jun 25, 2021

google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jun 25, 2021

firelizzard18 force-pushed the testing-api branch from ccb25a9 to 6cf3c3d Compare June 25, 2021 06:45

firelizzard18 force-pushed the testing-api branch from f005945 to 77f3623 Compare July 8, 2021 22:10

firelizzard18 added 20 commits August 13, 2021 11:08

src/goTestExplorer: improve readability

075fea0

Change function names and add comments.

src/goTestExplorer: add tests

a846bc9

src/goTestExplorer: add tests for workspace events

04a1899

src/goTestExplorer: handle document updates

27bd88f

src/goTestExplorer: default to not run benchmarks

29f9eb8

src/goTestExplorer: configure flat/nested packages

9bb5fcc

src/goTestExplorer: diff for examples

b34fe49

src/goTestExplorer: handle build failures

f59453d

src/goTestExplorer: update VSCode api

1a7266c

src/goTestExplorer: improve test output handling

aab8505

src/goTestExplorer: update to final API

15d1d2e

src/goTestExplorer: deal with benchmarks

43f273c

src/goTestExplorer: polish

c8258d2

src/goTestExplorer: cancel tests

42b6214

Update to VSCode 1.59

e225b49

src/goTestExplorer: fix run all tests

b4f6885

src/goTestExplorer: cleanup

f6c1077

src/goTestExplorer: fixes

1633f67

Fix a dumb mistake and remove a TODO.

src/goTestExplorer: address review comments

5b058a2

src/goTestExplorer: address comments

9ad01bf

firelizzard18 force-pushed the testing-api branch from 7d8ab99 to a9a5551 Compare August 13, 2021 17:09

src/goTestExplorer: support VSCode 1.58

5e41e65

firelizzard18 force-pushed the testing-api branch from a9a5551 to 5e41e65 Compare August 13, 2021 17:13

package.json: add Testing category

bf637ce

firelizzard18 mentioned this pull request Aug 13, 2021

Allow extensions to conditionally register menu contributions based on VSCode version microsoft/vscode#130796

Closed

docs: update commands and settings

4da995c

feitian124 mentioned this pull request Aug 16, 2021

Completing setup vscode for getting start pingcap/tidb-dev-guide#47

Closed

src/goTestExplorer: back to 1.59

59af29b

gopherbot closed this Aug 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src/goTestExplorer: implement a test provider for the new test api #1590

src/goTestExplorer: implement a test provider for the new test api #1590

firelizzard18 commented Jun 25, 2021 •

edited by hyangah

Loading

google-cla bot commented Jun 25, 2021

firelizzard18 commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

src/goTestExplorer: implement a test provider for the new test api #1590

src/goTestExplorer: implement a test provider for the new test api #1590

Conversation

firelizzard18 commented Jun 25, 2021 • edited by hyangah Loading

google-cla bot commented Jun 25, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

firelizzard18 commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 25, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 26, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jun 30, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

firelizzard18 commented Jun 25, 2021 •

edited by hyangah

Loading