New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippet/go.json: add code snippet for variable block #2481

Closed

karthikraobr wants to merge 1 commit into golang:master from karthikraobr:feature/vars-code-snippet

Contributor

karthikraobr commented Sep 25, 2022 •

edited

Loading

This PR adds a code snippet for creating a variable block. It also fixes running instructions for the mac in the contributing guide.


add code snippet for variable block

b5a8b7c

karthikraobr changed the title ~~Add code snippet for variable block~~ snippet/go.json: add code snippet for variable block

Collaborator

gopherbot commented Sep 25, 2022

This PR (HEAD: b5a8b7c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/434255 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Collaborator

gopherbot commented Sep 27, 2022

Message from Jamal Carvalho:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/434255.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Oct 10, 2022

Message from Hyang-Ah Hana Kim:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/434255.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Oct 10, 2022

Message from Hyang-Ah Hana Kim:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/434255.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Oct 10, 2022

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/648028ae-6c05-4ac4-8deb-0e2f3b65225f

Please don’t reply on this GitHub thread. Visit golang.org/cl/434255.
After addressing review feedback, remember to publish your drafts!

Collaborator

gopherbot commented Oct 10, 2022

Message from kokoro:

Patch Set 2: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/648028ae-6c05-4ac4-8deb-0e2f3b65225f

Please don’t reply on this GitHub thread. Visit golang.org/cl/434255.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


snippet/go.json: add code snippet for variable block

fc6d532

This PR adds a code snippet for creating a variable block. It also fixes running instructions for the mac in the contributing guide.

Change-Id: Id53db46887b6bb2efbe71ab2e8f03837808d331c
GitHub-Last-Rev: b5a8b7c
GitHub-Pull-Request: #2481
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/434255
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>

Collaborator

gopherbot commented Oct 10, 2022

This PR is being closed because golang.org/cl/434255 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment