Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json: make additionalProperties false for object type settings #284

Closed
wants to merge 1 commit into from
Closed

package.json: make additionalProperties false for object type settings #284

wants to merge 1 commit into from

Conversation

9at8
Copy link
Contributor

@9at8 9at8 commented Jul 4, 2020 •
edited by hyangah
Loading

When I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting additionalProperties to false for the objects that don't expect more properties would be great!

As per microsoft/vscode#101810, vscode (v1.48) will hide the "Add item" button if and only if additionalProperties is false and all known properties are present.

@9at8
Make additionalProperties false for object type settings
695aa78 
I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting `"additionalProperties": false` for the objects that don't expect more properties would be great!
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Jul 4, 2020
@9at8
Copy link
Contributor Author

9at8 commented Jul 4, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jul 4, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: 695aa78) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/240907 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

@hyangah hyangah mentioned this pull request Jul 8, 2020
Open
@gopherbot
Copy link
Collaborator

Message from Aditya Thakral:

Patch Set 1:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

@hyangah hyangah changed the title Make additionalProperties false for object type settings package.json: make additionalProperties false for object type settings Jul 15, 2020
@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jul 15, 2020
@9at8 @hyangah
package.json: make additionalProperties false for object type settings
e8e56a0 
When I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting `additionalProperties` to `false` for the objects that don't expect more properties would be great!

As per microsoft/vscode#101810, vscode (v1.48) will hide the "Add item" button if and only if `additionalProperties` is `false` and all known properties are present.

Change-Id: I92380610b24f7cd6ee790f2e020b9c689c3ff25b
GitHub-Last-Rev: 695aa78
GitHub-Pull-Request: #284
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240907
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/240907.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/240907 has been merged.

@gopherbot gopherbot closed this Jul 15, 2020
@9at8 9at8 deleted the patch-1 branch July 15, 2020 22:12
gopherbot pushed a commit that referenced this pull request Aug 17, 2020
@hyangah
package.json: allow additional properties for alternateTools
e1603dd 
In #284, we started
to use additionalProperties to support vscode's new setting UI
feature available for object type settings if the settings
accept only predefined properties.

 "go.alternateTools" can accept more tool names than those
specified in package.json. So, correct its additionalProperties
value.

Fixes #526

Change-Id: I72d2a7e72702d13bc74ed72a34a93756569bb041
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/248619
Reviewed-by: Suzy Mueller <suzmue@golang.org>
gopherbot pushed a commit that referenced this pull request Sep 1, 2020
@hyangah
[release] package.json: allow additional properties for alternateTools
903ccc7 
In #284, we started
to use additionalProperties to support vscode's new setting UI
feature available for object type settings if the settings
accept only predefined properties.

 "go.alternateTools" can accept more tool names than those
specified in package.json. So, correct its additionalProperties
value.

Fixes #526

Change-Id: I72d2a7e72702d13bc74ed72a34a93756569bb041
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/248619
Reviewed-by: Suzy Mueller <suzmue@golang.org>
(cherry picked from commit e1603dd)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/252120
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9at8 @googlebot @gopherbot