Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Does golangci-lint-action support minor patches? #38

Closed
denis-tingaikin opened this issue Jul 12, 2020 · 3 comments
Closed
Labels
question Further information is requested

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jul 12, 2020

Look's like with golangci-lint-action I can't use golangci-lint with minor patches, for example, version: v1.28.3 is not working. Is this behavior expected?

@denis-tingaikin denis-tingaikin added the question Further information is requested label Jul 12, 2020
@SVilgelm
Copy link
Member

What is wrong with v1.28.3?

But looks like this is the expected behavior:

  if (parsedRequestedLintVersion.patch !== null) {
    throw new Error(
      `requested golangci-lint version '${requestedLintVersion}' was specified with the patch version, need specify only minor version`
    )
  }

https://github.com/golangci/golangci-lint-action/blob/master/src/version.ts#L53

@denis-tingaikin
Copy link
Member Author

What is wrong with v1.28.3?

There only one problem - I can not use it with golangci-lint-action :)

Do we need to allow to use of minor patches?

@SVilgelm
Copy link
Member

Could you provide more details? We tested it yesterday and it worked.
We had an issue with it, but it was resolved after we updated the assets.
Could you run one more time please, maybe it works now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants