ACN to valory + docs #95

Karrenbelt · 2022-03-28T22:26:49Z

Proposed changes

Changing authorship of ACN connection and protocol.
Updating ACN documentation accordingly.
Updating ACN tests accordingly
Pinning protobuf ==3.19.4 in Pipfile and tox.ini
Updating workflow.yml according to point 4.

Fixes

changed authorship on ACN protocol and connection.
changed p2p_libp2p* connection versions to 0.1.0
updating documentation accordingly and included p2p-connection.md

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

I have read the CONTRIBUTING doc
I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
Lint and unit tests pass locally with my changes and CI passes too
I have added tests that prove my fix is effective or that my feature works
I have checked that code co- left protocol version at 1.1.0verage does not decrease.
I have added necessary documentation (if appropriate)
Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

docs/p2p-connection.md

docs/acn-internals.md

docs/p2p-connection.md

DavidMinarsch

Now there's an issue on golang tests. I'll let you fix them.

tests/test_packages/test_connections/test_p2p_libp2p_client/test_communication.py

Pipfile

codecov-commenter · 2022-04-06T12:25:38Z

Codecov Report

Merging #95 (4cf16d5) into main (953ad45) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 4cf16d5 differs from pull request most recent head 019f22b. Consider uploading reports for the commit 019f22b to get more accurate results

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   96.89%   96.92%   +0.03%     
==========================================
  Files         307      301       -6     
  Lines       24258    23920     -338     
==========================================
- Hits        23504    23185     -319     
+ Misses        754      735      -19

Flag	Coverage Δ
unittests	`96.92% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aea/helpers/serializers.py	`100.00% <100.00%> (ø)`
packages/valory/protocols/acn/__init__.py
packages/valory/protocols/acn/acn_pb2.py
packages/valory/protocols/acn/custom_types.py
packages/valory/protocols/acn/dialogues.py
packages/valory/protocols/acn/message.py
packages/valory/protocols/acn/serialization.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953ad45...019f22b. Read the comment docs.

Adamantios · 2022-04-06T17:11:09Z

aea/helpers/serializers.py

+from google.protobuf.struct_pb2 import (  # pylint: disable=no-name-in-module
+    ListValue,
+    Struct,
+)


Is # pylint: disable=no-name-in-module required after pinning protobuf version?

No it's not required anymore

DavidMinarsch · 2022-04-06T17:40:01Z

.github/workflows/workflow.yml

        with:
-          go-version: "^1.14.0"
+          go-version: "1.17.7"


We use different versions throughout this file. That's not desirable. I propose we use >=1.14.0 <=1.17.0 throughout as this makes explicit the ranges for which it works.

Feel free to open an issue for it.

DavidMinarsch

LGTM

Karrenbelt added 3 commits March 22, 2022 12:13

fix:changing links

413859d

chore:copies p2p-connection.md

1636152

docs:updating to open-aea

f0ed3a9

DavidMinarsch reviewed Mar 29, 2022

View reviewed changes

docs/p2p-connection.md Outdated Show resolved Hide resolved

docs/p2p-connection.md Show resolved Hide resolved

docs/p2p-connection.md Outdated Show resolved Hide resolved

docs/p2p-connection.md Outdated Show resolved Hide resolved

docs/p2p-connection.md Outdated Show resolved Hide resolved

Karrenbelt added 4 commits March 30, 2022 22:46

docs:updating to open-aea and open-acn

d7d0cc4

docs:fix links and packages

e532628

Merge remote-tracking branch 'origin/main' into ACN-docs

b6a660e

trigger

d8d1231

DavidMinarsch reviewed Mar 31, 2022

View reviewed changes

docs/acn-internals.md Outdated Show resolved Hide resolved

Karrenbelt added 8 commits April 1, 2022 22:51

chore:move acn to packages.valory

70380cb

chore:move acn protocol and libp2p connection

3535791

chore:author to valory

599ae43

grunt:hardcoded paths

09899f0

grunt:linters

71cd0a2

fix: workflow python@master -> python@v3

1c0bdc5

fix: adding packages/valory to makefile

cfca288

fix: revert

51fef35

Karrenbelt changed the title ~~[WIP] ACN docs~~ [WIP] ACN to valory + docs Apr 1, 2022

Karrenbelt added 5 commits April 2, 2022 11:55

chore:versions to 0.1.0

f67bcb8

docs:author and version

5bdde4a

fix:updating hashes

61abae1

fix:prefixing author

c64fa60

fix:author prefix

9d36d50

Karrenbelt force-pushed the ACN-docs branch 2 times, most recently from ce23608 to bd5a01a Compare April 2, 2022 10:48

fix:add generate_all_protocols to Makefile

a149089

Karrenbelt force-pushed the ACN-docs branch from bd5a01a to a149089 Compare April 2, 2022 10:57

DavidMinarsch reviewed Apr 5, 2022

View reviewed changes

docs/p2p-connection.md Outdated Show resolved Hide resolved

DavidMinarsch added 2 commits April 4, 2022 19:53

fix: address protobuf error by fixing version

5fa041d

fix: pin version of protobuf in tox too

6a5b8b9

DavidMinarsch requested changes Apr 5, 2022

View reviewed changes

tests/test_packages/test_connections/test_p2p_libp2p_client/test_communication.py Outdated Show resolved Hide resolved

Pipfile Show resolved Hide resolved

Karrenbelt force-pushed the ACN-docs branch 2 times, most recently from 80d1a64 to 6a5b8b9 Compare April 5, 2022 16:15

8baller and others added 5 commits April 5, 2022 19:26

test: increased time for failing test.

bf42590

pinning go version for protolint install

67c067b

final go version

da780ae

final go version

93f1051

fix:golangci-lint

e580c0a

Karrenbelt force-pushed the ACN-docs branch 2 times, most recently from 708db18 to 8805548 Compare April 6, 2022 07:26

Karrenbelt force-pushed the ACN-docs branch from 91e9233 to bb57194 Compare April 6, 2022 13:01

fix:PR feedback

4cf16d5

Karrenbelt force-pushed the ACN-docs branch from bb57194 to 4cf16d5 Compare April 6, 2022 13:08

test:update connection and protocol path

019f22b

Adamantios reviewed Apr 6, 2022

View reviewed changes

DavidMinarsch reviewed Apr 6, 2022

View reviewed changes

DavidMinarsch approved these changes Apr 6, 2022

View reviewed changes

DavidMinarsch changed the title ~~[WIP] ACN to valory + docs~~ ACN to valory + docs Apr 6, 2022

DavidMinarsch merged commit d487fc4 into main Apr 6, 2022

DavidMinarsch deleted the ACN-docs branch April 6, 2022 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ACN to valory + docs #95

ACN to valory + docs #95

Karrenbelt commented Mar 28, 2022 •

edited

Loading

DavidMinarsch left a comment

codecov-commenter commented Apr 6, 2022 •

edited

Loading

Adamantios Apr 6, 2022

DavidMinarsch Apr 6, 2022

DavidMinarsch Apr 6, 2022

DavidMinarsch Apr 6, 2022

DavidMinarsch left a comment

ACN to valory + docs #95

ACN to valory + docs #95

Conversation

Karrenbelt commented Mar 28, 2022 • edited Loading

Proposed changes

Fixes

Types of changes

Checklist

Further comments

DavidMinarsch left a comment

Choose a reason for hiding this comment

codecov-commenter commented Apr 6, 2022 • edited Loading

Codecov Report

Adamantios Apr 6, 2022

Choose a reason for hiding this comment

DavidMinarsch Apr 6, 2022

Choose a reason for hiding this comment

DavidMinarsch Apr 6, 2022

Choose a reason for hiding this comment

DavidMinarsch Apr 6, 2022

Choose a reason for hiding this comment

DavidMinarsch left a comment

Choose a reason for hiding this comment

Karrenbelt commented Mar 28, 2022 •

edited

Loading

codecov-commenter commented Apr 6, 2022 •

edited

Loading