Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify golangci-lint executable in the action #631

Closed
2 tasks done
nascentcore-eng opened this issue Dec 24, 2022 · 2 comments
Closed
2 tasks done

Specify golangci-lint executable in the action #631

nascentcore-eng opened this issue Dec 24, 2022 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@nascentcore-eng
Copy link

Welcome

  • Yes, I understand that the GitHub action repository is not the repository of golangci-lint itself.
  • Yes, I've searched similar issues on GitHub and didn't find any.

Your feature request related to a problem? Please describe.

The current action download golangci-lint executable

github action cache usually make that fast

I'd like to have the ability to specify custome path to the golangci-lint
for example, if action runs inside a container, include golangci-lint in the container's path

Describe the solution you'd like.

Provide an option to specify a path in the action runtime filesystem.

Describe alternatives you've considered.

No alternative I can think of

Additional context.

No response

@atzoum
Copy link

atzoum commented Jan 7, 2023

👍 this would also allow for using custom golangci-lint binaries, containing private linters which is now not possible

@ldez
Copy link
Member

ldez commented Feb 8, 2023

duplicate of #540

@ldez ldez closed this as completed Feb 8, 2023
@ldez ldez added duplicate This issue or pull request already exists and removed enhancement New feature or request labels Feb 8, 2023
@ldez ldez mentioned this issue Mar 20, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants