Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support golangci-lint patch version #98

Closed
sayboras opened this issue Oct 3, 2020 · 0 comments · Fixed by #101
Closed

Support golangci-lint patch version #98

sayboras opened this issue Oct 3, 2020 · 0 comments · Fixed by #101
Labels
enhancement New feature or request

Comments

@sayboras
Copy link
Member

sayboras commented Oct 3, 2020

Currently, only version X.Y is supported, it is internally derive the last patch version of golangci-lint. However, sometimes, I would love to have some experience with my local dev and CI.

Propose: Support X.Y.Z version in config.

  • if X.Y.Z version is passed, honour it 👍
  • if X.Y version is passed, keep the same behaviour as it is right now.
@sayboras sayboras added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 3, 2020
@sayboras sayboras mentioned this issue Oct 3, 2020
Merged
@sayboras sayboras added the hacktoberfest Label for hacktoberfest label Oct 3, 2020
@sayboras sayboras mentioned this issue Oct 11, 2020
Closed
daixiang0 pushed a commit that referenced this issue Oct 17, 2020
@sayboras
feat(version): Support for patch verison (#101)
a1c5369 
This commit is to support X.Y.Z version in config.

- if X.Y.Z version is passed, honour it 👍
- if X.Y version is passed, keep the same behaviour
as it is right now.

Closes #98

Signed-off-by: Tam Mach <sayboras@yahoo.com>
zikaeroh added a commit to zikaeroh/golangci-lint-action that referenced this issue Feb 21, 2021
@zikaeroh
Update "version" config in README example
cd12e7c 
golangci#98 was closed by golangci#101, but the README still says that only a major-minor version is accepted. It also says that this field is required, but `action.yml` says otherwise. Copy the description from `action.yml` into the README for consistency.
@zikaeroh zikaeroh mentioned this issue Feb 21, 2021
Merged
SVilgelm pushed a commit that referenced this issue Feb 23, 2021
@zikaeroh
Update "version" config in README example (#167)
23487cb 
#98 was closed by #101, but the README still says that only a major-minor version is accepted. It also says that this field is required, but `action.yml` says otherwise. Copy the description from `action.yml` into the README for consistency.
@ldez ldez removed good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest Label for hacktoberfest labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(version): Support for patch version
2 participants
@ldez @sayboras