-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Setup-Go #403
Remove Setup-Go #403
Conversation
Signed-off-by: Steve Coffman <steve@khanacademy.org>
Signed-off-by: Steve Coffman <steve@khanacademy.org>
Thank you very much for this PR, it looks good to me. Just one note: please update all examples in readme, add the go installation step. I need few day for testing. |
great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add go installation step in all examples in the README.md file
- remove skip-go-installation option from action.yml and from README.md files
- Add a note in the readme that v3 requires explicit go installation step
Here is the PR I use for testing the changes for this action: sv-tools/mongoifc#49 |
Signed-off-by: Steve Coffman <steve@khanacademy.org>
I think I have now corrected the references you mention, but please let me know if additional references to setup-go are present, or if I should make any further edits. |
Thanks for doing this work @StevenACoffman - great to see it finally in the new |
This was removed in golangci/golangci-lint-action#403
Per discussion in #365, this removes
setup-go
dep.Until this PR is landed, we are stuck and unable to upgrade any dependencies, fix any vulns, due to the inability to build the
setup-go
package.So now we remove it and then we will need to explicitly install go, like:
Of course, it will then require us to bump v3, but I imagine there are further documentation changes required so I am not doing that in this PR.
Signed-off-by: Steve Coffman steve@khanacademy.org