Run action on different platforms #65
Conversation
SVilgelm
force-pushed
the
platforms
branch
10 times, most recently
from
cce3e22
to
89b7eef
Compare
src/cache.ts
Outdated
| @@ -34,7 +39,7 @@ const getIntervalKey = (invalidationIntervalDays: number): string => { | |||
|
|
|||
| async function buildCacheKeys(): Promise<string[]> { | |||
| const keys = [] | |||
| let cacheKey = `golangci-lint.cache-` | |||
| let cacheKey = util.format("golangci-lint.cache-%s-%s-", os.platform(), os.arch()) | |||
There was a problem hiding this comment.
just curious why cache key needs to be updated ?
There was a problem hiding this comment.
I thought it might be mixed up with caches for different platforms, but looks like everything works fine. Reverted back
src/install.ts
Outdated
| } | ||
| const s = util.format("%s-%s.%s", platform, arch, ext) | ||
| if (s != defaultPlatform) { | ||
| return versionConfig.AssetURL.replace(defaultPlatform, s) |
There was a problem hiding this comment.
understand that you are using AssetURL to cope with existing logic. I am thinking about using TargetVersion and then construct URL based on version. Then later, we can just remove redundant AssetURL in golangci-lint.
Anyway, I am feel free to ignore this comment.
There was a problem hiding this comment.
to get rid of the AssetURL we need to came up with more complex logic of finding the latest version and latest patch version. Let's use it for now
There was a problem hiding this comment.
I see what you mean, yes, we can use TargetVersion to build the AssetURL
|
@SVilgelm yes, i tested |
|
@sayboras I already know how to retire the assets :) But it will take some time to implement, I'm newbie in typescript, we just need to use GitHub API to request the list of releases instead of assets and do same with sorting, but we need to be careful with the performance, It can be slower than using the assets, but will see |
What should be exactly done? |
|
@ernado since I changed the os matrix the name of status check were caged as well, and there is no |
|
Now I'm not sure what to enable. Can't find "build-and-test" here. |
|
@ernado looks like all 3 should be enabled: test (*) |
Closes #24
installLintfunction to modify the AssetURL to download platform specifying binary and use proper extractor (.tar.gzand.zip)