1. Added reference

2. Added tests
3. Added config
4. Added linter

.golangci.reference.yml

@@ -658,6 +658,13 @@ linters-settings:
  - OPTIMIZE # marks code that should be optimized before merging
  - HACK # marks hack-around that should be removed before merging
 
+ gofactory:
+ # Default: []
+ blockedPkgs:
+ - github.com/author/repository/path/to/package
+ # Default: false
+ onlyBlockedPkgs: true
+
  gofmt:
  # Simplify code: gofmt with `-s` option.
  # Default: true
@@ -2339,6 +2346,7 @@ linters:
  - godot
  - godox
  - goerr113
+ - gofactory
  - gofmt
  - gofumpt
  - goheader
@@ -2459,6 +2467,7 @@ linters:
  - godot
  - godox
  - goerr113
+ - gofactory
  - gofmt
  - gofumpt
  - goheader

go.mod

@@ -69,6 +69,7 @@ require (
  github.com/leonklingele/grouper v1.1.1
  github.com/lufeee/execinquery v1.2.1
  github.com/macabu/inamedparam v0.1.2
+ github.com/maranqz/go-factory-lint v1.0.3
  github.com/maratori/testableexamples v1.0.0
  github.com/maratori/testpackage v1.1.1
  github.com/matoous/godox v0.0.0-20230222163458-006bad1f9d26

pkg/config/linters_settings.go

@@ -196,6 +196,7 @@ type LintersSettings struct {
  Gocyclo GoCycloSettings
  Godot GodotSettings
  Godox GodoxSettings
+ Gofactory GoFactoryLintSettings
  Gofmt GoFmtSettings
  Gofumpt GofumptSettings
  Goheader GoHeaderSettings
@@ -474,6 +475,11 @@ type GodoxSettings struct {
  Keywords []string
 }
 
+type GoFactoryLintSettings struct {
+ BlockedPkgs map[string]map[string]string `mapstructure:"BlockedPkgs"`
+ OnlyBlockedPkgs string `mapstructure:"OnlyBlockedPkgs"`
+}
+
 type GoFmtSettings struct {
  Simplify bool
  RewriteRules []GoFmtRewriteRule `mapstructure:"rewrite-rules"`

pkg/golinters/gofactorylint.go

@@ -0,0 +1,30 @@
+package golinters
+
+import (
+ "github.com/maranqz/go-factory-lint"
+ "golang.org/x/tools/go/analysis"
+
+ "github.com/golangci/golangci-lint/pkg/config"
+ "github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewGoFactoryLint(settings *config.GoFactoryLintSettings) *goanalysis.Linter {
+ a := factory.NewAnalyzer()
+
+ cfg := make(map[string]map[string]any)
+ if settings != nil {
+ cfg[a.Name] = map[string]any{}
+
+ if len(settings.BlockedPkgs) > 0 {
+ cfg[a.Name]["blockedPkgs"] = settings.BlockedPkgs
+ cfg[a.Name]["onlyBlockedPkgs"] = settings.OnlyBlockedPkgs
+ }
+ }
+
+ return goanalysis.NewLinter(
+ a.Name,
+ a.Doc,
+ []*analysis.Analyzer{a},
+ cfg,
+ ).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/lint/lintersdb/manager.go

@@ -90,6 +90,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
  gocycloCfg *config.GoCycloSettings
  godotCfg *config.GodotSettings
  godoxCfg *config.GodoxSettings
+ goFactoryCfg *config.GoFactoryLintSettings
  gofmtCfg *config.GoFmtSettings
  gofumptCfg *config.GofumptSettings
  goheaderCfg *config.GoHeaderSettings
@@ -174,6 +175,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
  gocycloCfg = &m.cfg.LintersSettings.Gocyclo
  godotCfg = &m.cfg.LintersSettings.Godot
  godoxCfg = &m.cfg.LintersSettings.Godox
+ goFactoryCfg = &m.cfg.LintersSettings.Gofactory
  gofmtCfg = &m.cfg.LintersSettings.Gofmt
  gofumptCfg = &m.cfg.LintersSettings.Gofumpt
  goheaderCfg = &m.cfg.LintersSettings.Goheader
@@ -488,6 +490,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
  WithLoadForGoAnalysis().
  WithURL("https://github.com/Djarvur/go-err113"),
 
+ linter.NewConfig(golinters.NewGoFactoryLint(goFactoryCfg)).
+ WithSince("next_version").
+ WithPresets(linter.PresetStyle).
+ WithURL("https://github.com/maranqz/go-factory-lint"),
+
  linter.NewConfig(golinters.NewGofmt(gofmtCfg)).
  WithSince("v1.0.0").
  WithPresets(linter.PresetFormatting).

test/testdata/configs/gofactory.yml

@@ -0,0 +1,4 @@
+linters-settings:
+ gofactory:
+ blockedPkgs: []
+ onlyBlockedPkgs: false

test/testdata/gofactory/app.go

@@ -0,0 +1,24 @@
+package gofactory
+
+import "github.com/golangci/golangci-lint/test/testdata/gofactory/nested"
+
+type Struct struct{}
+
+var (
+ globalStruct = nested.Struct{} // want `Use factory for nested.Struct`
+ globalStructPtr = &nested.Struct{} // want `Use factory for nested.Struct`
+)
+
+func fn() {
+ _ = nested.Struct{} // want `Use factory for nested.Struct`
+ _ = &nested.Struct{} // want `Use factory for nested.Struct`
+
+ _ = []nested.Struct{{}, nested.Struct{}} // want `Use factory for nested.Struct`
+ _ = []*nested.Struct{{}, &nested.Struct{}} // want `Use factory for nested.Struct`
+
+ call(nested.Struct{}) // want `Use factory for nested.Struct`
+
+ _ = []Struct{{}, {}}
+}
+
+func call(_ nested.Struct) {}

test/testdata/gofactory/nested/factory.go

@@ -0,0 +1,3 @@
+package nested
+
+type Struct struct{}