Skip to content

Commit

Permalink
remove hardcoded limit for typecheck
Browse files Browse the repository at this point in the history
  • Loading branch information
ldez committed Mar 24, 2021
1 parent 950b9b6 commit 4285e92
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions pkg/result/processors/max_per_file_from_linter.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ type MaxPerFileFromLinter struct {
var _ Processor = &MaxPerFileFromLinter{}

func NewMaxPerFileFromLinter(cfg *config.Config) *MaxPerFileFromLinter {
maxPerFileFromLinterConfig := map[string]int{
"typecheck": 3,
}
maxPerFileFromLinterConfig := map[string]int{}

if !cfg.Issues.NeedFix {
// if we don't fix we do this limiting to not annoy user;
// otherwise we need to fix all issues in the file at once
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/notcompiles/typecheck_many_issues.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ func TypeCheckBadCalls() {
typecheckNotExists1.F1() // ERROR "undeclared name: `typecheckNotExists1`"
typecheckNotExists2.F2() // ERROR "undeclared name: `typecheckNotExists2`"
typecheckNotExists3.F3() // ERROR "undeclared name: `typecheckNotExists3`"
typecheckNotExists4.F4()
typecheckNotExists4.F4() // ERROR "undeclared name: `typecheckNotExists4`"
}

0 comments on commit 4285e92

Please sign in to comment.