tests: add delete last line

golangci · Jan 2, 2025 · cd971d2 · cd971d2
1 parent c860f67
commit cd971d2
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/pkg/golinters/internal/diff.go b/pkg/golinters/internal/diff.go
@@ -252,9 +252,9 @@ func ExtractDiagnosticFromPatch(
 
 func toDiagnostic(ft *token.File, change Change, adjLine int) analysis.Diagnostic {
 	from := change.From + adjLine
-	if from > ft.LineCount() {
-		from = ft.LineCount()
-	}
+	// if from > ft.LineCount() {
+	// 	from = ft.LineCount()
+	// }
 
 	start := ft.LineStart(from)
 

diff --git a/pkg/golinters/internal/diff_test.go b/pkg/golinters/internal/diff_test.go
@@ -19,6 +19,13 @@ func Test_parse(t *testing.T) {
 		log      logutils.Log
 		expected []Change
 	}{
+		{
+			diff: "delete_last_line.diff",
+			expected: []Change{{
+				From: 10,
+				To:   10,
+			}},
+		},
 		{
 			diff: "delete_only_first_lines.diff",
 			expected: []Change{{

diff --git a/pkg/golinters/internal/testdata/delete_last_line.diff b/pkg/golinters/internal/testdata/delete_last_line.diff
@@ -0,0 +1,9 @@
+diff --git i/main.go w/main.go
+index ef3cbb7..52a7925 100644
+--- i/main.go
++++ w/main.go
+@@ -7,4 +7,3 @@ import (
+ func main() {
+        fmt.Println("hello world")
+ }
+-