Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running multiple instances serialy #1301

Closed
rski opened this issue Aug 11, 2020 · 0 comments · Fixed by #1302
Closed

Allow running multiple instances serialy #1301

rski opened this issue Aug 11, 2020 · 0 comments · Fixed by #1302
Labels
enhancement New feature or improvement

Comments

@rski
Copy link
Contributor

rski commented Aug 11, 2020

Is your feature request related to a problem? Please describe.
When golangci-lint runs, --allow-parallel-runners defaults to false, so multiple instances can't run at the same time. It's also kind of dubious whether the cache will work well on parallel runs, so I would like a middle solution where I can run multiple instances, each waiting for the lock.

Describe the solution you'd like
An --allow-serial-runners flag, that will remove the flock timeout, effectively waiting forever until all other instances finish.

I have a change for this ready, I'm filing this first for reference/posterity
@rski rski added the enhancement New feature or improvement label Aug 11, 2020
rski added a commit to rski/golangci-lint that referenced this issue Aug 11, 2020
@rski
Allow for serializing multiple golangci-lint invocations
ccec735 
By default, golangci-lint fails after five seconds if another instance
is running. It is possible to disable that, but the discussion around
whether the cache is safe to use concurrently is not exactly full of
confidence. Add a flag that allows golangci-lint to wait forever
instead of failing.

see golangci#1301
@rski rski mentioned this issue Aug 11, 2020
Merged
@SVilgelm SVilgelm linked a pull request Aug 22, 2020 that will close this issue
Allow for serializing multiple golangci-lint invocations #1302
Merged
daixiang0 pushed a commit that referenced this issue Aug 28, 2020
@rski
Allow for serializing multiple golangci-lint invocations (#1302)
1a2a672 
By default, golangci-lint fails after five seconds if another instance
is running. It is possible to disable that, but the discussion around
whether the cache is safe to use concurrently is not exactly full of
confidence. Add a flag that allows golangci-lint to wait forever
instead of failing.

see #1301
@snyk-bot snyk-bot mentioned this issue Jun 22, 2021
Closed
@snyk-bot snyk-bot mentioned this issue Sep 21, 2021
Open
@snyk-bot snyk-bot mentioned this issue Oct 28, 2021
Open
@snyk-bot snyk-bot mentioned this issue Dec 2, 2021
Open
@snyk-bot snyk-bot mentioned this issue Jan 30, 2022
Open
@alpha-phoenicis alpha-phoenicis mentioned this issue Oct 27, 2022
Open
@DevenGengan DevenGengan mentioned this issue Feb 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow for serializing multiple golangci-lint invocations rski/golangci-lint
1 participant
@rski