Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go/packages #178

Closed
jirfag opened this issue Aug 2, 2018 · 3 comments
Closed

Use go/packages #178

jirfag opened this issue Aug 2, 2018 · 3 comments
Labels
enhancement New feature or improvement

Comments

@jirfag
Copy link
Member

jirfag commented Aug 2, 2018 •
edited
Loading

To properly analyze go modules we need to use go/packages
@jirfag jirfag added the enhancement New feature or improvement label Aug 2, 2018
This was referenced Sep 2, 2018
Closed
Closed
@caarlos0 caarlos0 mentioned this issue Sep 15, 2018
Closed
@caarlos0
Copy link

any pointers? I may be able to help with this :)

@nezorflame nezorflame mentioned this issue Oct 4, 2018
Closed
@jirfag
Copy link
Member Author

jirfag commented Oct 22, 2018

Hi!
I've almost implemented it, but I have some troubles with cgo. I need some time to investigate it, maybe go/packages has bugs. I hope to finish within a week

jirfag added a commit that referenced this issue Oct 25, 2018
@jirfag
Fix #237, fix #178: use go/packages
4858a4a 
Use go/packages instead of x/tools/loader: it allows to work
with go modules and speedups loading of packages with the help
of build cache.

A lot of linters became "fast": they are enabled by --fast now and
work in 1-2 seconds. Only unparam, interfacer and megacheck
are "slow" linters now.

Average project is analyzed 20-40% faster than before if all linters are
enabled! If we enable all linters except unparam, interfacer and
megacheck analysis is 10-20x faster!
jirfag added a commit that referenced this issue Oct 28, 2018
@jirfag
Fix #237, fix #178: use go/packages
ad660f2 
Use go/packages instead of x/tools/loader: it allows to work
with go modules and speedups loading of packages with the help
of build cache.

A lot of linters became "fast": they are enabled by --fast now and
work in 1-2 seconds. Only unparam, interfacer and megacheck
are "slow" linters now.

Average project is analyzed 20-40% faster than before if all linters are
enabled! If we enable all linters except unparam, interfacer and
megacheck analysis is 10-20x faster!
jirfag added a commit that referenced this issue Oct 28, 2018
@jirfag
Fix #237, fix #178: use go/packages
917c0d7 
Use go/packages instead of x/tools/loader: it allows to work
with go modules and speedups loading of packages with the help
of build cache.

A lot of linters became "fast": they are enabled by --fast now and
work in 1-2 seconds. Only unparam, interfacer and megacheck
are "slow" linters now.

Average project is analyzed 20-40% faster than before if all linters are
enabled! If we enable all linters except unparam, interfacer and
megacheck analysis is 10-20x faster!
jirfag added a commit that referenced this issue Oct 28, 2018
@jirfag
Fix #237, fix #178: use go/packages
36ce2e6 
Use go/packages instead of x/tools/loader: it allows to work
with go modules and speedups loading of packages with the help
of build cache.

A lot of linters became "fast": they are enabled by --fast now and
work in 1-2 seconds. Only unparam, interfacer and megacheck
are "slow" linters now.

Average project is analyzed 20-40% faster than before if all linters are
enabled! If we enable all linters except unparam, interfacer and
megacheck analysis is 10-20x faster!
jirfag added a commit that referenced this issue Oct 28, 2018
@jirfag
Fix #237, fix #178: use go/packages
101fbca 
Use go/packages instead of x/tools/loader: it allows to work
with go modules and speedups loading of packages with the help
of build cache.

A lot of linters became "fast": they are enabled by --fast now and
work in 1-2 seconds. Only unparam, interfacer and megacheck
are "slow" linters now.

Average project is analyzed 20-40% faster than before if all linters are
enabled! If we enable all linters except unparam, interfacer and
megacheck analysis is 10-20x faster!
@jirfag jirfag closed this as completed in 0421bac Oct 28, 2018
@jirfag
Copy link
Member Author

jirfag commented Oct 28, 2018

go/packages are supported in release v1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caarlos0 @jirfag