-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change not to use linter with AGPL lisence #3337
Comments
Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors. |
Hello, our license is GPL, you already have to disclose your code. https://github.com/golangci/golangci-lint/blob/master/LICENSE
The AGPL variant is about usage over a network, in the case of golangci-lint it doesn't make a real difference. Feel free to ask https://github.com/leonklingele/grouper for changing the license. |
I'm not happy to be forced by Google to follow their rules. If the license is not changed we will just drop the linter. |
Thank you for listening to my opinion. I'm waiting for that. |
@ldez How is it going? |
Just be clear: our license is GPL, you must already disclose any changes you make in the golangci-lint code, the grouper license doesn't change that. As you can see, we are still waiting for an answer of @leonklingele |
I'm a bit busy these days but will get back to this asap. |
@ldez In my understanding, the difference between GPL and AGPL is disclosure range. As you said, GPL has surely obligation to disclose codes if developer provides binary using a module with that license in public, but when they provides web service using that in server side, they don't have to disclose their codes. |
Just to better understand the problem here. It’s because AGPL is not allowed at Google and we want the project to be usable there?
|
It’s because AGPL is not allowed at Google and other companies. |
Your feature request related to a problem? Please describe.
Hi, I've used golangci-lint but after upgrading its version to latest one, I found the linter with AGPL lisence was added(github.com/leonklingele/grouper, PR: #2497).
I can't find discussion around it, but I don't think it's a good idea to use that because user might have to disclose their source codes.
Describe the solution you'd like.
Changing its license or not to use it
Describe alternatives you've considered.
If there is a special reason, we might not have to change it.
Additional context.
No response
The text was updated successfully, but these errors were encountered: