go1.21 support

[ldez]

Update

2023-08-11

go1.21 is now officially fully supported since v1.54.1.

2023-08-10

The problems with ruleguard/gocritic are fixed.
A new release will happen quickly.

2023-08-09

go1.21 is now officially supported since v1.54.0 but there are still problems:

• ruleguard (a "rule" inside go-critic) doesn't work with go1.21. go1.21: load rules: parse rules file: typechecker error: ...: could not import quasilyte/go-ruleguard#449
• in some cases go-critic fails to load its built-in/embedded rules. go1.21: load embedded ruleguard rules: rules/rules.go:13: can't load fmt go-critic/go-critic#1359

---

Is golangci-lint support go1.21?

No, and yes.

Basically, golangci-lint supports Go versions lower or equal to the Go version used to build it.

Go version (build)	Supported Go versions (code)	Not supported Go versions (code)
go1.20	<= go1.20 (go1.20, go1.19, etc.)	> go1.20 (go1.21, go1.22, etc.)
go1.19	<= go1.19 (go1.19, go1.18, etc.)	> go1.19 (go1.20, go1.21, etc.)

The current binaries from the releases page and the Docker images have been built with go1.20 and will be built with go1.20 as long as go1.21 is not GA.
So those binaries/images don't support go1.21.

https://golangci-lint.run/usage/faq/#which-go-versions-are-supported

In addition, of the Go version used to build it, some linters could need to be updated to support newer versions of Go, and internal pieces of golangci-lint could also need to be updated.

You can follow the PR #3922 to see the progress on this topic.

---

Sponsoring is a good way to sustain open source maintainers: sponsor me

[ldez]

go1.21 has been released.

But currently ruleguard (a "rule" inside go-critic) doesn't work with go1.21.
quasilyte/go-ruleguard#449

We have several solutions:

• fix ruleguard (the best but not trivial)
• disable ruleguard inside go-critic for go1.21 (can be complex)
• disable ruleguard inside golangci-lint for go1.21 (not trivial but I think it's possible)
• disable ruleguard inside golangci-lint
• disable go-critic inside golangci-lint for go1.21 (the worst but easy, I think we don't need to do that)

[andig]

In terms of a quick fix and limited-effort band-aid it sounds as if

disable ruleguard inside golangci-lint

might be the best option right now as long a fixing the root cause is not possible?

[ldez]

I also think this is the best move: #3922 (comment)

[cornelk]

gci needs to be upgraded by daixiang0/gci#163 to support the new packages

[CubicrootXYZ]

go 1.21 adds a new toolchain directive to the go.mod. This currently throws an error:

level=error msg="Running error: context loading failed: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: errors parsing go.mod:\n/builds/xxxxxx/go.mod:5: unknown directive: toolchain\n"

[ldez]

The go.mod structure inside x/mod has been updated in v0.11.0
https://github.com/golang/mod/blob/62c7e578f1a7275d934c99dd48715525bd52b17e/modfile/rule.go#L40

x/mod has been updated to v0.11.0 inside golangci-lint: #3943

[LKaemmerling]

Collegue of @CubicrootXYZ here, yep this is correct, but there was no new release since then. So golangci-lint v1.53.3 was released on 15. June; the MR you refer to is from 09.July

[ldez]

So golangci-lint v1.53.3 was released on 15. June; the MR you refer to is from 09.July

Yes, I explained that in the issue description: #3933 (comment)

My previous answer was just facts related to the comment.

[kikihakiem]

I have an issue with golangci-lint after I upgraded to go1.21. This is the command I used to install from source and run the linter:

$ go1.21.0 install github.com/golangci/golangci-lint/cmd/golangci-lint@master
$ golangci-lint run

And this is the error message:

WARN [runner] Can't run linter goanalysis_metalinter: buildssa: failed to load package : could not load export data: no export data for "log/slog" 
ERRO Running error: 1 error occurred:
        * can't run linter goanalysis_metalinter: buildssa: failed to load package : could not load export data: no export data for "log/slog"

It was working fine before the upgrade. Please note that the slog package was imported from golang.org/x/exp/slog.
If this issue is not related to golangci-lint, what could be the cause of it? Could you please shed some light?

[ldez]

can you provide a reproducible example?

If you are facing a problem related to Go1.21, the best way to contribute is to open a new issue and provide the following information:

golangci-lint --version

cat .golangci.yml

go version && go env

golangci-lint cache clean
golangci-lint run -v

And a code example or link to a public repository.

[ldez]

go1.21 is now officially fully supported since v1.54.1.

---

Sponsoring is a good way to sustain open source maintainers: sponsor me